Re: [Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On 06/19/2013 05:28 PM, Kevin Wolf wrote:
> We don't have to duplicate the definition any more now that we may refer
> to a type instead.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qapi-schema.json | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a80ee40..ee19d6a 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1669,8 +1669,7 @@
>  # Since 0.14.0
>  ##
>  { 'command': 'blockdev-snapshot-sync',
> -  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
> -            '*mode': 'NewImageMode'} }
> +  'data': 'BlockdevSnapshot' }

There's still duplication of the doc comments, but as we don't have
anything parsing doc comments to convert them into a more usable form
yet, that can be something we worry about later.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]