From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upycw-0008R4-1h for qemu-devel@nongnu.org; Fri, 21 Jun 2013 06:31:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Upycu-00059x-D5 for qemu-devel@nongnu.org; Fri, 21 Jun 2013 06:31:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Upycu-00059G-5S for qemu-devel@nongnu.org; Fri, 21 Jun 2013 06:31:32 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5LAVVcx032557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Jun 2013 06:31:31 -0400 Message-ID: <51C42B80.7030206@redhat.com> Date: Fri, 21 Jun 2013 11:31:28 +0100 From: Eric Blake MIME-Version: 1.0 References: <1371659287-14331-1-git-send-email-kwolf@redhat.com> <1371659287-14331-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1371659287-14331-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JDPONSJEMABKQWRIXEKH" Subject: Re: [Qemu-devel] [PATCH 3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JDPONSJEMABKQWRIXEKH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2013 05:28 PM, Kevin Wolf wrote: > We don't have to duplicate the definition any more now that we may refe= r > to a type instead. >=20 > Signed-off-by: Kevin Wolf > --- > qapi-schema.json | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index a80ee40..ee19d6a 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1669,8 +1669,7 @@ > # Since 0.14.0 > ## > { 'command': 'blockdev-snapshot-sync', > - 'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',= > - '*mode': 'NewImageMode'} } > + 'data': 'BlockdevSnapshot' } There's still duplication of the doc comments, but as we don't have anything parsing doc comments to convert them into a more usable form yet, that can be something we worry about later. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2JDPONSJEMABKQWRIXEKH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRxCuAAAoJEKeha0olJ0Nqba4H/i4A3He8SRnbK9MtHXUw5xsX x0NkJVPZ1hh53Rg+QJ2hxqVx1jU8jAsBJRkHuOjKv99QW38npagYXBD0rezwzRpD QQeQgn8HzkIg9+1cK0GCTeYVCpSTiC/6w4A53buZ5Ssc381EIhOdas8cRd6vDOhn tzdtirs27u7L5/m+2lD0GBnlklIE9vcGhikfZWrqqmDXH0oAX6PHzWcWEB+/crtD x5aMBov9prtaAso30AfQ69IDwJy7U6bxLPMcx2AsaC1OVeT6Vq6N4yKgbhY9Ppuj im2xFeG5k16AQeeJzdoRZyxhgywExPHHUJ/jlOskyOq89rMP1Mhl9XdXU62G/1E= =ES4k -----END PGP SIGNATURE----- ------enig2JDPONSJEMABKQWRIXEKH--