From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq7bq-00007f-OH for qemu-devel@nongnu.org; Fri, 21 Jun 2013 16:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uq7bo-0006vK-8s for qemu-devel@nongnu.org; Fri, 21 Jun 2013 16:07:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq7bo-0006uq-1w for qemu-devel@nongnu.org; Fri, 21 Jun 2013 16:07:00 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5LK6v7w032082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Jun 2013 16:06:58 -0400 Message-ID: <51C4B25F.2060603@redhat.com> Date: Fri, 21 Jun 2013 21:06:55 +0100 From: Eric Blake MIME-Version: 1.0 References: <1371831528-1128-1-git-send-email-fsimonce@redhat.com> In-Reply-To: <1371831528-1128-1-git-send-email-fsimonce@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2AMFUQTTEKEMBOQGPSGVF" Subject: Re: [Qemu-devel] [PATCH] block: add apparent-size to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Federico Simoncelli Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AMFUQTTEKEMBOQGPSGVF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/21/2013 05:18 PM, Federico Simoncelli wrote: > This patch adds the apparent-size entry to the query-block output. > The value represents the apparent size in bytes of the image, e.g. > file size (including the blocks not yet allocated) or block device > size. >=20 > Signed-off-by: Federico Simoncelli > --- > block/qapi.c | 3 ++- > qapi-schema.json | 4 +++- > qmp-commands.hx | 1 + > 3 files changed, 6 insertions(+), 2 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -222,6 +222,8 @@ > # > # @actual-size: #optional actual size on disk in bytes of the image > # > +# @apparent-size: apparent size in bytes of the image Worth adding a '(since 1.6)' notation. Is there any more documentation you can list here to differentiate between the different sizes? > +# > # @dirty-flag: #optional true if image is not cleanly closed > # > # @cluster-size: #optional size of a cluster in bytes > @@ -244,7 +246,7 @@ > =20 > { 'type': 'ImageInfo', > 'data': {'filename': 'str', 'format': 'str', '*dirty-flag': 'bool', > - '*actual-size': 'int', 'virtual-size': 'int', > + '*actual-size': 'int', 'virtual-size': 'int', 'apparent-siz= e': 'int', Long line; may be worth wrapping. Is this parameter always present, even if it is identical to 'actual-size' for some file formats, or should it be marked optional? qemu-img should be enhanced to output the new information. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2AMFUQTTEKEMBOQGPSGVF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRxLJfAAoJEKeha0olJ0NqNeAH/RXo6Zy+WxEWUnVaacIOMK26 56PF8aw7ZsujF/k31C3GPoyr4AbcfpnB6WCe2Vp1UuTOSIz4DI07hWwN17XveFrT PdWFrN2DNUbeqVcH5qTAuwYyj9t+8APNEx9q55vXpim9uAp8fL4Pcr7doVbFmahG 2ofrAh1skgJJ1LjQWcwg6EJ5fRhr+mlsiBwstBfXu/o+lMGKKQDVkuK4q+3z6FMt nTxELibohzaXR0gvx56MB+5VMurfWWmghgmApuMw+06UZwJGd1IySctyY3XsBliG GhGs1p9pLxbx+tQ3440DF0/h3oMjndN62wzP11DIXBjEtMThaZDP6BN8sdOr5ko= =n2vh -----END PGP SIGNATURE----- ------enig2AMFUQTTEKEMBOQGPSGVF--