From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Ed Maste <emaste@freebsd.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment
Date: Sun, 23 Jun 2013 11:20:39 -0700 [thread overview]
Message-ID: <51C73C77.8030208@twiddle.net> (raw)
In-Reply-To: <CAFEAcA-98aqd2pqBicD53kduv-HrbcVcuOwv3wGDyVoCkOj29A@mail.gmail.com>
On 06/22/2013 03:58 AM, Peter Maydell wrote:
> On 22 June 2013 03:10, Richard Henderson <rth@twiddle.net> wrote:
>> + ldflags="$ldflags $textseg_ldflags"
>> fi
>>
>> echo "LDFLAGS+=$ldflags" >> $config_target_mak
>
> Should we really be putting this in LDFLAGS? That seems
> likely to end up getting accidentally applied in places
> where we don't want it (helper binaries, etc). It seems
> like it would be more robust to have it in a special
> variable which we only ever explicitly apply to linking
> the foo-linux-user binary.
This is within the target subdir, not in the main top level. So... What helper
binaries?
Modifying ldflags is what we do now. If you think that we should change to a
different variable, then I think that should be a separate change.
r~
next prev parent reply other threads:[~2013-06-23 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 2:10 [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment Richard Henderson
2013-06-22 10:58 ` Peter Maydell
2013-06-23 18:20 ` Richard Henderson [this message]
2013-06-23 18:22 ` Peter Maydell
2013-06-24 19:45 ` Ed Maste
2013-07-02 15:12 ` Richard Henderson
2013-07-09 15:43 ` Richard Henderson
2013-07-10 19:33 ` Anthony Liguori
2015-01-07 18:02 ` Stefan Weil
2015-01-07 18:44 ` Richard Henderson
2015-01-07 20:37 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C73C77.8030208@twiddle.net \
--to=rth@twiddle.net \
--cc=emaste@freebsd.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).