From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uqou7-0008Pl-SN
	for qemu-devel@nongnu.org; Sun, 23 Jun 2013 14:20:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uqou5-0000Z0-Bk
	for qemu-devel@nongnu.org; Sun, 23 Jun 2013 14:20:47 -0400
Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:42774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uqou4-0000Yj-O0
	for qemu-devel@nongnu.org; Sun, 23 Jun 2013 14:20:45 -0400
Received: by mail-pa0-f47.google.com with SMTP id kl14so9964731pab.6
	for <qemu-devel@nongnu.org>; Sun, 23 Jun 2013 11:20:43 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51C73C77.8030208@twiddle.net>
Date: Sun, 23 Jun 2013 11:20:39 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1371867016-7660-1-git-send-email-rth@twiddle.net>
	<CAFEAcA-98aqd2pqBicD53kduv-HrbcVcuOwv3wGDyVoCkOj29A@mail.gmail.com>
In-Reply-To: <CAFEAcA-98aqd2pqBicD53kduv-HrbcVcuOwv3wGDyVoCkOj29A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text
	segment
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Ed Maste <emaste@freebsd.org>, qemu-devel@nongnu.org

On 06/22/2013 03:58 AM, Peter Maydell wrote:
> On 22 June 2013 03:10, Richard Henderson <rth@twiddle.net> wrote:
>> +  ldflags="$ldflags $textseg_ldflags"
>>  fi
>>
>>  echo "LDFLAGS+=$ldflags" >> $config_target_mak
> 
> Should we really be putting this in LDFLAGS? That seems
> likely to end up getting accidentally applied in places
> where we don't want it (helper binaries, etc). It seems
> like it would be more robust to have it in a special
> variable which we only ever explicitly apply to linking
> the foo-linux-user binary.

This is within the target subdir, not in the main top level.  So... What helper
binaries?

Modifying ldflags is what we do now.  If you think that we should change to a
different variable, then I think that should be a separate change.


r~