From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42437)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Ur2VX-0003dw-3O
	for qemu-devel@nongnu.org; Mon, 24 Jun 2013 04:52:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Ur2VU-0000dk-Bf
	for qemu-devel@nongnu.org; Mon, 24 Jun 2013 04:52:19 -0400
Message-ID: <51C8094F.10500@redhat.com>
Date: Mon, 24 Jun 2013 10:54:39 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1372055996-4072-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1372055996-4072-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 00/13] A bunch of little socket +
 chardev fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On 06/24/13 08:39, Gerd Hoffmann wrote:
>   Hi,
> 
> Here is v2 of the series, addressing Michaels review comments.
> 
> cheers,
>   Gerd
> 
> Gerd Hoffmann (13):
>   qemu-socket: zero-initialize SocketAddress
>   qemu-socket: drop pointless allocation
>   qemu-socket: catch monitor_get_fd failures
>   qemu-char: check optional fields using has_*
>   qemu-char: use more specific error_setg_* variants
>   qemu-char: print notification to stderr
>   qemu-char: fix documentation for telnet+wait socket flags
>   qemu-char: don't leak opts on error
>   qemu-char: use ChardevBackendKind in in CharDriver
>   qemu-char: minor mux chardev fixes
>   qemu-char: add -chardev mux support
>   qemu-char: report udb backend errors
>   qemu-socket: don't leak opts on error
> 
>  include/sysemu/char.h |    2 +-
>  qapi-schema.json      |    7 ++++---
>  qemu-char.c           |   45 ++++++++++++++++++++++++++++++++-------------
>  util/qemu-sockets.c   |    9 ++++-----
>  4 files changed, 41 insertions(+), 22 deletions(-)
> 

I think 11/13 doesn't qualify for qemu-trivial. In any case, it does
seem correct, like the rest.

With the commit message fixups from Michael: series

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo