From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur7fR-0001sx-Vx for qemu-devel@nongnu.org; Mon, 24 Jun 2013 10:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ur7fQ-0001lr-ID for qemu-devel@nongnu.org; Mon, 24 Jun 2013 10:22:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur7fQ-0001lY-AI for qemu-devel@nongnu.org; Mon, 24 Jun 2013 10:22:52 -0400 Message-ID: <51C85630.9060400@redhat.com> Date: Mon, 24 Jun 2013 16:22:40 +0200 From: Martin Kletzander MIME-Version: 1.0 References: <1371714876-2317-1-git-send-email-armbru@redhat.com> In-Reply-To: <1371714876-2317-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/8] Guest memory allocation fixes & cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, stefano.stabellini@eu.citrix.com, mtosatti@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net On 06/20/2013 09:54 AM, Markus Armbruster wrote: > All I wanted to do is exit(1) instead of abort() on guest memory > allocation failure [07/08]. But that lead me into a minor #ifdef bog, > and here's what I brought back. Enjoy! > > Testing: > * Christian Borntraeger reports v1 works fine under LPAR (new S390 > KVM, i.e. generic allocation) and as second guest under z/VM (old > S390 KVM, i.e. legacy S390 allocation). Thanks for testing, and for > catching a stupid mistake. v2 differs from v1 only in code that > isn't reachable on S390. > > Changes since v1: > * 5/8: Fix assertion in qemu_ram_remap() (Paolo) > * All other patches unchanged except for Acked-by in commit messages > Changes since RFC: > * 1-3+8/8 unchanged except for commit message tweaks > * 4+6/8 rewritten to address Paolo's review > * 5/8 rewritten: don't fix dead code, just assert it's dead > * 7/8 fix mistakes caught by Richard Henderson and Peter Maydell > > Markus Armbruster (8): > exec: Fix Xen RAM allocation with unusual options > exec: Clean up fall back when -mem-path allocation fails > exec: Reduce ifdeffery around -mem-path > exec: Simplify the guest physical memory allocation hook > exec: Drop incorrect & dead S390 code in qemu_ram_remap() > exec: Clean up unnecessary S390 ifdeffery > exec: Don't abort when we can't allocate guest memory > pc_sysfw: Fix ISA BIOS init for ridiculously big flash > > exec.c | 121 ++++++++++++++++++++++++++---------------------- > hw/block/pc_sysfw.c | 5 +- > include/exec/cpu-all.h | 2 - > include/exec/exec-all.h | 2 + > include/sysemu/kvm.h | 5 -- > kvm-all.c | 13 ------ > target-s390x/kvm.c | 23 +++------ > util/oslib-posix.c | 4 +- > util/oslib-win32.c | 5 +- > 9 files changed, 78 insertions(+), 102 deletions(-) > I appreciate this. Works great on x86 and arm architectures. From libvirt's POV there's only better error reporting to fix, but that's a rare race with only a small impact, nothing to do on qemu's side, I guess. This is what we desired to have, thanks, Martin