From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrTQJ-00060m-P0 for qemu-devel@nongnu.org; Tue, 25 Jun 2013 09:36:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrTQD-0005Bz-69 for qemu-devel@nongnu.org; Tue, 25 Jun 2013 09:36:43 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:52915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrTQC-0005Bo-VB for qemu-devel@nongnu.org; Tue, 25 Jun 2013 09:36:37 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Jun 2013 07:36:35 -0600 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id B1100C90045 for ; Tue, 25 Jun 2013 09:36:31 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5PDaWED308316 for ; Tue, 25 Jun 2013 09:36:32 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5PDaWxb017882 for ; Tue, 25 Jun 2013 10:36:32 -0300 Message-ID: <51C99CDF.9070103@linux.vnet.ibm.com> Date: Tue, 25 Jun 2013 09:36:31 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1372125485-11795-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372125485-11795-5-git-send-email-mrhines@linux.vnet.ibm.com> <87zjue1qx3.fsf@elfo.elfo> In-Reply-To: <87zjue1qx3.fsf@elfo.elfo> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 04/15] rdma: export throughput w/ MigrationStats QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com On 06/25/2013 05:27 AM, Juan Quintela wrote: > mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> This exposes throughput (in megabits/sec) through QMP. >> >> Reviewed-by: Paolo Bonzini >> Reviewed-by: Chegu Vinod >> Tested-by: Chegu Vinod >> Tested-by: Michael R. Hines >> Signed-off-by: Michael R. Hines >> @@ -154,8 +154,10 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict) >> >> if (info->has_status) { >> monitor_printf(mon, "Migration status: %s\n", info->status); >> - monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n", >> - info->total_time); >> + if (info->has_total_time) { >> + monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n", >> + info->total_time); >> + } >> if (info->has_expected_downtime) { >> monitor_printf(mon, "expected downtime: %" PRIu64 " milliseconds\n", >> info->expected_downtime); > This chunk don't belong to this patch. > > for the rest: > > Reviewed-by: Juan Quintela > Acknowledged - will drop the hunk in the next version. - Michael