From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrTUW-0001eX-3l for qemu-devel@nongnu.org; Tue, 25 Jun 2013 09:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrTUQ-0006oe-Vi for qemu-devel@nongnu.org; Tue, 25 Jun 2013 09:41:04 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:40173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrTUQ-0006oX-SW for qemu-devel@nongnu.org; Tue, 25 Jun 2013 09:40:58 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 25 Jun 2013 09:40:58 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 4ED7EC9006E for ; Tue, 25 Jun 2013 09:40:54 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5PDetsR285556 for ; Tue, 25 Jun 2013 09:40:55 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5PDes8E028355 for ; Tue, 25 Jun 2013 10:40:55 -0300 Message-ID: <51C99DE6.8010606@linux.vnet.ibm.com> Date: Tue, 25 Jun 2013 09:40:54 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1372125485-11795-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372125485-11795-15-git-send-email-mrhines@linux.vnet.ibm.com> <8761x21pvx.fsf@elfo.elfo> In-Reply-To: <8761x21pvx.fsf@elfo.elfo> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com On 06/25/2013 05:49 AM, Juan Quintela wrote: > mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> As described in the previous patch, until now, the MIG_STATE_SETUP >> state was not really a 'formal' state. It has been used as a 'zero' state >> (what we're calling 'NONE' here) and QEMU has been unconditionally transitioning >> into this state when the QMP migration command was called. Instead we want to >> introduce MIG_STATE_NONE, which is our starting state in the state machine, and >> then immediately transition into the MIG_STATE_SETUP state when the QMP migrate >> command is issued. >> >> In order to do this, we must delay the transition into MIG_STATE_ACTIVE until >> later in the migration_thread(). This is done to be able to timestamp the amount of >> time spent in the SETUP state for proper accounting to the user during >> an RDMA migration. >> >> Furthermore, the management software, until now, has never been aware of the >> existence of the SETUP state whatsoever. This must change, because, timing of this >> state implies that the state actually exists. >> >> These two patches cannot be separated because the 'query_migrate' QMP >> switch statement needs to know how to handle this new state transition. >> >> Tested-by: Michael R. Hines >> Signed-off-by: Michael R. Hines >> @@ -316,6 +321,7 @@ static void migrate_fd_cancel(MigrationState *s) >> { >> DPRINTF("cancelling migration\n"); >> >> + migrate_set_state(s, MIG_STATE_SETUP, MIG_STATE_CANCELLED); >> migrate_set_state(s, MIG_STATE_ACTIVE, MIG_STATE_CANCELLED); >> } > This chunk is wrong. > > we can call qme_migrate_cancel() at any point, and it is going to be > called normally from MIG_STATE_ACTIVE. > > > migrate_set_satet(s, s->state, MIG_STATE_CANCELLED) > > should do the trick. Or something like that, what do you think? > > Later, Juan. > > > Great idea, thank you. - Michael