From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrUeo-00063T-NY
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 10:55:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrUel-00015X-DK
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 10:55:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23842)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrUek-00015D-WE
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 10:55:43 -0400
Message-ID: <51C9AF56.9030800@redhat.com>
Date: Tue, 25 Jun 2013 16:55:18 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372125485-11795-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1372125485-11795-15-git-send-email-mrhines@linux.vnet.ibm.com>
	<8761x21pvx.fsf@elfo.elfo> <51C96D39.2020603@redhat.com>
	<51C99EC6.2050008@linux.vnet.ibm.com> <51C9A0D8.6050800@redhat.com>
	<51C9AF15.8000404@linux.vnet.ibm.com>
In-Reply-To: <51C9AF15.8000404@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE
 and change MIG_STATE_SETUP state transition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, chegu_vinod@hp.com, knoel@redhat.com

Il 25/06/2013 16:54, Michael R. Hines ha scritto:
>>>
>> Do those few lines of code change the protocol?  If yes, I'll go against
>> all my previous recommendations and suggest a #define.  If no, it is
>> fine to leave it for later, but I would still suggest posting the patch
>> on the list just for information.
> 
> Ok, you got it - no it does not change the protocol.
> I'll use a #define and send it out with a new version for review.

Make sure you send an additional patch on top of these 15.

Paolo