From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrWJe-0002Rk-Cj
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 12:42:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrWJd-0000hT-7v
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 12:42:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61527)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrWJc-0000hM-Vh
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 12:42:01 -0400
Message-ID: <51C9C847.1030706@redhat.com>
Date: Tue, 25 Jun 2013 18:41:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372125485-11795-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1372125485-11795-12-git-send-email-mrhines@linux.vnet.ibm.com>
	<20130625163149.GA10901@dhcp-192-168-178-175.profitbricks.localdomain>
In-Reply-To: <20130625163149.GA10901@dhcp-192-168-178-175.profitbricks.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, chegu_vinod@hp.com

Il 25/06/2013 18:31, Vasilis Liaskovitis ha scritto:
> Then I think qemu_rdma_dump_id can segfault trying to dereference a null verbs
> structure. The dump_id function should check for non-NULL verbs argument,
> or the dump should be made only in the (verbs != NULL) if clause.
> 
> Disabling the dump_id above, I have rdma_resolve_addr() problems on the source
> VM side (getting RDMA_CM_EVENT_ADDR_ERROR instead of
> RDMA_CM_EVENT_ADDR_RESOLVED).
> 
> I assume that is because of the null verbs structure destination problem above.
> qemu_rdma_dest_prepare() will always fail with a NULL verbs argument:

FWIW, I don't think this should block merging this patch.  We will
always find one more bug after merging 2500 lines of code.

Paolo