From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UrYCJ-0005yK-DN
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 14:42:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UrYCH-0003qe-FT
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 14:42:35 -0400
Received: from mail-ee0-x22f.google.com ([2a00:1450:4013:c00::22f]:52776)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UrYCH-0003qS-4y
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 14:42:33 -0400
Received: by mail-ee0-f47.google.com with SMTP id e49so6916436eek.34
	for <qemu-devel@nongnu.org>; Tue, 25 Jun 2013 11:42:32 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51C9E490.7090304@redhat.com>
Date: Tue, 25 Jun 2013 20:42:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372184516-32397-1-git-send-email-peter.maydell@linaro.org>
	<1372184516-32397-3-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1372184516-32397-3-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version
 of the GPT timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Paul Brook <paul@codesourcery.com>

Il 25/06/2013 20:21, Peter Maydell ha scritto:
> @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev)
>  
>      sysbus_init_irq(dev, &s->irq);
>      memory_region_init_io(&s->iomem, &imx_timerg_ops,
> -                          s, "imxg-timer",
> +                          s, TYPE_IMX_GPT,
>                            0x00001000);
>      sysbus_init_mmio(dev, &s->iomem);
>  

There was some agreement that this is not a good change.

Paolo