From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urgxp-0003kp-MW for qemu-devel@nongnu.org; Wed, 26 Jun 2013 00:04:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Urgxo-0002vs-Kd for qemu-devel@nongnu.org; Wed, 26 Jun 2013 00:04:13 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:48991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urgxo-0002v6-23 for qemu-devel@nongnu.org; Wed, 26 Jun 2013 00:04:12 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Jun 2013 13:55:06 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id AA8782CE8051 for ; Wed, 26 Jun 2013 14:03:59 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5Q3mveM4850106 for ; Wed, 26 Jun 2013 13:49:00 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5Q43uAW005249 for ; Wed, 26 Jun 2013 14:03:56 +1000 Message-ID: <51CA681B.5030203@linux.vnet.ibm.com> Date: Wed, 26 Jun 2013 12:03:39 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1372078125-31085-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1372078125-31085-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1372078125-31085-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V2 5/7] monitor: support sub commands in auto completion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: pbonzini@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com ÓÚ 2013-6-24 20:48, Wenchao Xia дµÀ: > This patch allow auot completion work normal in sub command case, > "info block [DEVICE]" can auto complete now, by re-enter the completion > function. Also, original "info" is treated as a special case, now it is > treated as a sub command group, global variable info_cmds is not used > any more. > > "help" command is still treated as a special case, since it is not a sub > command group but want to auto complete command in root command table. > > Signed-off-by: Wenchao Xia > --- > monitor.c | 36 ++++++++++++++++++++++++------------ > 1 files changed, 24 insertions(+), 12 deletions(-) > > diff --git a/monitor.c b/monitor.c > index aa641de..f364a0d 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4179,10 +4179,11 @@ static const char *next_arg_type(const char *typestr) > return (p != NULL ? ++p : typestr); > } > > -static void monitor_find_completion(Monitor *mon, > - const char *cmdline) > +static void monitor_find_completion_by_table(Monitor *mon, > + const mon_cmd_t *cmd_table, > + const char *cmdline) > { > - const char *cmdname; > + const char *cmdname, *p; > char *args[MAX_ARGS]; > int nb_args, i, len; > const char *ptype, *str; > @@ -4212,12 +4213,12 @@ static void monitor_find_completion(Monitor *mon, > else > cmdname = args[0]; > readline_set_completion_index(mon->rs, strlen(cmdname)); > - for (cmd = mon->cmd_table; cmd->name != NULL; cmd++) { > + for (cmd = cmd_table; cmd->name != NULL; cmd++) { > cmd_completion(mon, cmdname, cmd->name); > } > } else { > /* find the command */ > - for (cmd = mon->cmd_table; cmd->name != NULL; cmd++) { > + for (cmd = cmd_table; cmd->name != NULL; cmd++) { > if (compare_cmd(args[0], cmd->name)) { > break; > } > @@ -4226,6 +4227,17 @@ static void monitor_find_completion(Monitor *mon, > goto cleanup; > } > > + /* locate next valid string in original cmdline used by re-enter */ > + p = cmdline + strlen(args[0]); > + while (qemu_isspace(*p)) { > + p++; > + } > + Here it can't handle command start with space such as " blk", I plan make parse_cmdline() return additional const char **args_cmdline, which point to cmdline correspond to each args. Just want to mention it to save reviewer's time, I'll fix it with any other comments:). > + if (cmd->sub_table) { > + monitor_find_completion_by_table(mon, cmd->sub_table, p); > + goto cleanup; > + } > + > ptype = next_arg_type(cmd->args_type); > for(i = 0; i < nb_args - 2; i++) { > if (*ptype != '\0') { > @@ -4252,13 +4264,7 @@ static void monitor_find_completion(Monitor *mon, > bdrv_iterate(block_completion_it, &mbs); > break; > case 's': > - /* XXX: more generic ? */ > - if (!strcmp(cmd->name, "info")) { > - readline_set_completion_index(mon->rs, strlen(str)); > - for(cmd = info_cmds; cmd->name != NULL; cmd++) { > - cmd_completion(mon, str, cmd->name); > - } > - } else if (!strcmp(cmd->name, "sendkey")) { > + if (!strcmp(cmd->name, "sendkey")) { > char *sep = strrchr(str, '-'); > if (sep) > str = sep + 1; > @@ -4284,6 +4290,12 @@ cleanup: > } > } > > +static void monitor_find_completion(Monitor *mon, > + const char *cmdline) > +{ > + return monitor_find_completion_by_table(mon, mon->cmd_table, cmdline); > +} > + > static int monitor_can_read(void *opaque) > { > Monitor *mon = opaque; > -- Best Regards Wenchao Xia