From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrjeL-0005GX-IE
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 02:56:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrjeK-0005w4-Np
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 02:56:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UrjeK-0005vq-GI
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 02:56:16 -0400
Message-ID: <51CA9086.80802@redhat.com>
Date: Wed, 26 Jun 2013 08:56:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372184516-32397-1-git-send-email-peter.maydell@linaro.org>
	<1372184516-32397-3-git-send-email-peter.maydell@linaro.org>
	<51C9E490.7090304@redhat.com>
	<CAFEAcA-yhQ2kzzT10wHmEJ7vGF1viKCGL77kmMGOukksvKzQ_w@mail.gmail.com>
In-Reply-To: <CAFEAcA-yhQ2kzzT10wHmEJ7vGF1viKCGL77kmMGOukksvKzQ_w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version
 of the GPT timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Paul Brook <paul@codesourcery.com>

Il 25/06/2013 22:53, Peter Maydell ha scritto:
> On 25 June 2013 19:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 25/06/2013 20:21, Peter Maydell ha scritto:
>>> @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev)
>>>
>>>      sysbus_init_irq(dev, &s->irq);
>>>      memory_region_init_io(&s->iomem, &imx_timerg_ops,
>>> -                          s, "imxg-timer",
>>> +                          s, TYPE_IMX_GPT,
>>>                            0x00001000);
>>>      sysbus_init_mmio(dev, &s->iomem);
>>>
>>
>> There was some agreement that this is not a good change.
> 
> I agree (and more so regarding the use of the macro in the
> vmstate name), but nobody actually posted any comment to
> that effect against any of the versions of this patch that
> got sent out for review...

Yeah, the timing was bad... Can you post a revert, though?

Paolo