From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42572)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Urjsp-0008TX-6d
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 03:11:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Urjsn-0002c4-Fk
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 03:11:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61392)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Urjsn-0002bs-8U
	for qemu-devel@nongnu.org; Wed, 26 Jun 2013 03:11:13 -0400
Message-ID: <51CA9407.1020104@redhat.com>
Date: Wed, 26 Jun 2013 09:11:03 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372184516-32397-1-git-send-email-peter.maydell@linaro.org>
	<1372184516-32397-3-git-send-email-peter.maydell@linaro.org>
	<51C9E490.7090304@redhat.com>
	<CAFEAcA-yhQ2kzzT10wHmEJ7vGF1viKCGL77kmMGOukksvKzQ_w@mail.gmail.com>
	<51CA9086.80802@redhat.com>
	<458051555.267249.1372230485548.JavaMail.root@tribudubois.net>
In-Reply-To: <458051555.267249.1372230485548.JavaMail.root@tribudubois.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version
 of the GPT timer.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: jcd@tribudubois.net
Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Il 26/06/2013 09:08, jcd@tribudubois.net ha scritto:
> For my own education, could you elaborate on the reason this is not a
> good change?

Quoting from http://article.gmane.org/gmane.comp.emulators.qemu/218078:

> The MemoryRegion name is free text that can be changed as desired and
> doesn't need to match the type name.
> 
> The TYPE_* constant serves to keep consistency between usages of the
> string literal but does not prohibit changing its value.
> 
> The VMStateDescription should thus not use the TYPE_* constant because
> it must not ever change for live migration. Renaming a type is a valid
> thing to do if there is no command line compatibility to keep (think
> board-level "xlnx.foo" -> "xlnx,foo").

Paolo