From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urkqi-0004dg-5p for qemu-devel@nongnu.org; Wed, 26 Jun 2013 04:13:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Urkqg-0007Jz-J5 for qemu-devel@nongnu.org; Wed, 26 Jun 2013 04:13:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urkqg-0007Ix-CJ for qemu-devel@nongnu.org; Wed, 26 Jun 2013 04:13:06 -0400 Message-ID: <51CAA28B.4050404@redhat.com> Date: Wed, 26 Jun 2013 10:12:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1370599329-16682-1-git-send-email-xiawenc@linux.vnet.ibm.com> <87ehcedsi7.fsf@blackfin.pond.sub.org> <51C032D2.80405@redhat.com> <51C5766F.8000704@weilnetz.de> <51C85B5D.7050702@redhat.com> <51C888CA.50603@weilnetz.de> In-Reply-To: <51C888CA.50603@weilnetz.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] build: remove compile warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Alexander Graf , qemu-devel@nongnu.org Il 24/06/2013 19:58, Stefan Weil ha scritto: >>> hw/ppc/spapr_hcall.c:188:1: warning: control reaches end of non-void >>> function [-Wreturn-type] >>> hw/ppc/spapr_pci.c:454:1: warning: control reaches end of non-void >>> function [-Wreturn-type] >> I think you could report this to mingw. GCC should handle "if (!0) >> foo()" just fine if foo is noreturn, perhaps the "assertion failure" >> runtime function is not noreturn in mingw. > > It's a gcc problem. Removing the assertion manually in the source > code and compiling with NDEBUG (which we do by default)results > in the same compiler warning. Huh? That seems wrong, assertions are there for a reason... Paolo