From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urksb-0005m7-PR for qemu-devel@nongnu.org; Wed, 26 Jun 2013 04:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Urksa-0007vW-Ha for qemu-devel@nongnu.org; Wed, 26 Jun 2013 04:15:05 -0400 Received: from mail-qa0-x22d.google.com ([2607:f8b0:400d:c00::22d]:62447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urksa-0007ug-CG for qemu-devel@nongnu.org; Wed, 26 Jun 2013 04:15:04 -0400 Received: by mail-qa0-f45.google.com with SMTP id ci6so1373287qab.11 for ; Wed, 26 Jun 2013 01:15:04 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51CAA301.2070703@redhat.com> Date: Wed, 26 Jun 2013 10:14:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372096130-24994-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1372096130-24994-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel , Alexander Graf , David Gibson Il 24/06/2013 19:48, Stefan Weil ha scritto: > Hi Alex, > > this mini series fixes the remaining compiler warnings in > my w32/w64 cross build environment on Debian wheezy. > > [PATCH 1/3] spapr: Use named enum for function remove_hpte > [PATCH 2/3] spapr: Fix compiler warning for some versions of gcc > [PATCH 3/3] spapr: Fix compiler warning for some versions of gcc > > The modifications are nearly trivial, but this time it would > be better if you could apply them to your patch queue. I think these patches are a bit backwards. The right fix is just to use abort() instead of assert(0). Paolo