From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Us6LF-0003UQ-J3
	for qemu-devel@nongnu.org; Thu, 27 Jun 2013 03:10:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Us6LE-0006Ai-Du
	for qemu-devel@nongnu.org; Thu, 27 Jun 2013 03:10:05 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51CBE544.8070306@redhat.com>
Date: Thu, 27 Jun 2013 09:09:56 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372238672-2614-1-git-send-email-famz@redhat.com>
	<20130626150523.GE2720@dhcp-200-207.str.redhat.com>
In-Reply-To: <20130626150523.GE2720@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vmdk: remove wrong calculation of relative
	path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org

Il 26/06/2013 17:05, Kevin Wolf ha scritto:
> Am 26.06.2013 um 11:24 hat Fam Zheng geschrieben:
>> > When creating image with backing file, the driver tries to calculate the
>> > relative path from created image file to backing file, but the path
>> > computation is incorrect. e.g.:
>> > 
>> >     $ qemu-img create -f vmdk -b vmdk-data-disk.vmdk vmdk-data-snapshot1
>> >     Formatting 'vmdk-data-snapshot1', fmt=vmdk size=10737418240
>> >     backing_file='vmdk-data-disk.vmdk' compat6=off zeroed_grain=off
>> > 
>> >     $ qemu-img info vmdk-data-snapshot1
>> >     image: vmdk-data-snapshot1
>> >     file format: vmdk
>> >     virtual size: 10G (10737418240 bytes)
>> >     disk size: 12K
>> > ->  backing file: disk.vmdk
>> > 
>> > The common part in file names, "vmdk-data-", is incorrectly forgotten by
>> > relative_path(). As the VMDK specification has no restriction on
>> > parentNameHint to be relative path, we simply remove this by using the
>> > backing_file option.
>> > 
>> > Signed-off-by: Fam Zheng <famz@redhat.com>
> Nice one. Thanks, applied to the block branch.

Cc: qemu-stable@nongnu.org