From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
Evgeny Voevodin <e.voevodin@samsung.com>,
patches@linaro.org, qemu-devel@nongnu.org,
Jean-Christophe DUBOIS <jcd@tribudubois.net>,
Peter Chubb <peter.chubb@nicta.com.au>,
Dmitry Solodkiy <d.solodkiy@samsung.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Maksim Kozlov <m.kozlov@samsung.com>
Subject: Re: [Qemu-devel] [PATCH] Avoid use of QOM type name macros in VMStateDescriptions
Date: Thu, 27 Jun 2013 13:41:37 +0200 [thread overview]
Message-ID: <51CC24F1.6040905@redhat.com> (raw)
In-Reply-To: <1372331024-3783-1-git-send-email-peter.maydell@linaro.org>
On 06/27/13 13:03, Peter Maydell wrote:
> The one I didn't touch was hw/usb/host-linux.c, since that changes
> the QOM typename and the VMStateDescription name depending on
> whether QEMU was built with CONFIG_USB_LIBUSB defined or not.
> That seems a bit fishy to me but I've left it alone.
vmstate probably should get a fixed "usb-host" name.
QOM changing is intentional and should stay that way, I want host-libusb
be the default when available, and host-linux be
available under another name, basically to simplify regression
testing in the phase of transitioning to host-libusb.
Long-term the whole host-linux (and host-bsd) code will simply
go away, so don't worry too much ;)
cheers,
Gerd
next prev parent reply other threads:[~2013-06-27 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 11:03 [Qemu-devel] [PATCH] Avoid use of QOM type name macros in VMStateDescriptions Peter Maydell
2013-06-27 11:41 ` Gerd Hoffmann [this message]
2013-06-30 7:20 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC24F1.6040905@redhat.com \
--to=kraxel@redhat.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=jcd@tribudubois.net \
--cc=m.kozlov@samsung.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).