From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsAaL-0002EI-0Y for qemu-devel@nongnu.org; Thu, 27 Jun 2013 07:41:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsAaJ-0001vz-G4 for qemu-devel@nongnu.org; Thu, 27 Jun 2013 07:41:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsAaJ-0001vk-88 for qemu-devel@nongnu.org; Thu, 27 Jun 2013 07:41:55 -0400 Message-ID: <51CC24F1.6040905@redhat.com> Date: Thu, 27 Jun 2013 13:41:37 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1372331024-3783-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1372331024-3783-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Avoid use of QOM type name macros in VMStateDescriptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Igor Mitsyanko , Evgeny Voevodin , patches@linaro.org, qemu-devel@nongnu.org, Jean-Christophe DUBOIS , Peter Chubb , Dmitry Solodkiy , Paolo Bonzini , Maksim Kozlov On 06/27/13 13:03, Peter Maydell wrote: > The one I didn't touch was hw/usb/host-linux.c, since that changes > the QOM typename and the VMStateDescription name depending on > whether QEMU was built with CONFIG_USB_LIBUSB defined or not. > That seems a bit fishy to me but I've left it alone. vmstate probably should get a fixed "usb-host" name. QOM changing is intentional and should stay that way, I want host-libusb be the default when available, and host-linux be available under another name, basically to simplify regression testing in the phase of transitioning to host-libusb. Long-term the whole host-linux (and host-bsd) code will simply go away, so don't worry too much ;) cheers, Gerd