From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [Qemu-devel] [RFC] qemu-img: add option -d in convert
Date: Thu, 27 Jun 2013 20:44:22 +0800 [thread overview]
Message-ID: <51CC33A6.2080206@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130627090139.GC14351@stefanha-thinkpad.redhat.com>
于 2013-6-27 17:01, Stefan Hajnoczi 写道:
> On Tue, Jun 25, 2013 at 07:14:19PM +0800, Wenchao Xia wrote:
>> 于 2013-6-25 17:13, Stefan Hajnoczi 写道:
>>> On Thu, Jun 20, 2013 at 04:59:17PM +0800, Wenchao Xia wrote:
>>>
>>> If I understand correctly, you have a backing chain with internal
>>> snapshots:
>>>
>>>> imageA(sn0)->imageB(sn0,sn1)->imageC(sn0)
>>>
>>> And you want to convert this to a chain of external snapshots:
>>>
>> What it looks like is convert into external snapshots, actually
>> requirement is get delta data from internal snapshot, external snapshots
>> have delta data by nature so it is a way to orginize it. This patch
>> will help get that delta data.
>
> Copying all the data out into external files in order to get
> is_allocated information seems very inefficient.
>
Forget to say, my purpose is not get is_allocated info, but
get the different data between two snapshots or images. Now qemu-img
can do it in-directly as the example shows, the -d option will make it
simpler and faster.
for example imageA(sn0, sn1, sn2), it will help to get different data
between sn0 and sn2.
An alternative way is let qemu-nbd export sn0 and sn2, then user
diff the data itself, but we lost the chance to use L1/L2 table
, allocated info, to accelerate it.
> We've discussed dirty block tracking APIs on the list several times.
> This seems related.
>
> Maybe it's time to tackle this properly for both external and internal
> snapshots.
>
> The reason why a dirty block tracking API is also helpful is that not
> all tools want to learn how to open different image file formats. (Even
> with libqblock.)
>
> The drity block tracking API gives them information which they can use
> together with a single interface like NBD or a libvirt block pread-style
> interface to read out dirty blocks.
>
> BTW we already have qemu-io -c map which prints out allocation
> information for an image file. If that command is extended to support
> -s then you can get your info easily.
>
> Stefan
>
--
Best Regards
Wenchao Xia
prev parent reply other threads:[~2013-06-27 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 8:59 [Qemu-devel] [RFC] qemu-img: add option -d in convert Wenchao Xia
2013-06-25 9:13 ` Stefan Hajnoczi
2013-06-25 11:14 ` Wenchao Xia
2013-06-27 9:01 ` Stefan Hajnoczi
2013-06-27 12:30 ` Wenchao Xia
2013-07-02 8:47 ` Stefan Hajnoczi
2013-06-27 12:44 ` Wenchao Xia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC33A6.2080206@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).