From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UsCKS-0000y6-ED
	for qemu-devel@nongnu.org; Thu, 27 Jun 2013 09:33:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UsCKR-0003cy-7q
	for qemu-devel@nongnu.org; Thu, 27 Jun 2013 09:33:40 -0400
Message-ID: <51CC3F2F.4090608@redhat.com>
Date: Thu, 27 Jun 2013 15:33:35 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1372339512-28149-1-git-send-email-armbru@redhat.com>
In-Reply-To: <1372339512-28149-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-char: Fix ID reuse after
 chardev-remove for qapi-based init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org

On 06/27/13 15:25, Markus Armbruster wrote:
> Commit 2c5f488 introduced qapi-based character device initialization
> as a new code path in qemu_chr_new_from_opts().  Unfortunately, it
> failed to store parameter opts in the new chardev.  Therefore,
> qemu_chr_delete() doesn't delete it.  Even though the device is gone,
> its options linger, and any attempt to create another one with the
> same ID fails.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
  Gerd