From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFpf-0002Io-LA for qemu-devel@nongnu.org; Thu, 27 Jun 2013 13:18:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsFpd-0007p1-2U for qemu-devel@nongnu.org; Thu, 27 Jun 2013 13:18:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsFpc-0007oi-OL for qemu-devel@nongnu.org; Thu, 27 Jun 2013 13:18:04 -0400 Message-ID: <51CC73B2.8070605@redhat.com> Date: Thu, 27 Jun 2013 11:17:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372078125-31085-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1372078125-31085-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2LQRTSCRFKEEULCSORRSK" Subject: Re: [Qemu-devel] [PATCH V2 0/7] monitor: support sub command group in auto completion and help List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: pbonzini@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2LQRTSCRFKEEULCSORRSK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/24/2013 06:48 AM, Wenchao Xia wrote: > Global variable *mon_cmds and *info_cmds are not used any more, *cur_mo= n is not > used in completion related functions. It is possible to create a monito= r with > different command table now, but that requirement do not exist yet, so = not changed > it to save trouble. Log command is still a special case now, may be it = can be converted > as sub group later. >=20 > Patch 1-3 make sure the functions can be re-entered safely. >=20 > V2: > General: > To discard *info_comds more graceful, help related function is modifi= ed to support > sub command too. > Patch 6/7 are added to improve help related functions. > Patch 5: not directly return to make sure args are freed. >=20 > Address Luiz's comments: > Split patch into small serial. s/serial/series/ (remember, "serial" is a device, "series" is a sequence of patches) > struct mon_cmd_t was not moved into header file, instead mon_cmnd_t *= cmd_table is > added as a member in struct Monitor. > 5/7: drop original code comments for "info" in monitor_find_completio= n(). >=20 > Wenchao Xia (7): > 1 monitor: discard global variable *cur_mon in completion functions > 2 monitor: discard global variable *mon_cmds > 3 monitor: discard global variable *info_cmds in help functions > 4 monitor: code move for parse_cmdline() > 5 monitor: support sub commands in auto completion > 6 monitor: improve "help" in auto completion for sub command > 7 monitor: improve "help" to allow show tip of single command in sub = group s/tip/details/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2LQRTSCRFKEEULCSORRSK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzHOyAAoJEKeha0olJ0NqDEoIAI17CSalaf/QKFL/15OVQp4/ PXPB6Y09uJOQT6rhntn0fpQ+cjR55DaroLXUO86m8YB7gqByuQ9eeRPx/ig/Zwrq rEnZQwK0rvz48XMqiP6uOpsT7LKs/jLwPlIbMlLDho2lIPEC1GgarDR0KGexNkPc xDoQcd2UbC2rEQLxET4XeL5FbCPrBWcegAVL6VOfS6mzGjsmmoeN7EGDLyBdsyU1 sgGbybD9+Q/daDws0+BdFCrlPmAqh7OwFlI+0Px9fRmXQUvqt3cg18YRLLsAXmHF wUVVdAZF3wY9DqD3mbjz+XaCs8/H3Mwh6S8iHJ13NdGtHQLmkybC3r4X0Om90bg= =e+0p -----END PGP SIGNATURE----- ------enig2LQRTSCRFKEEULCSORRSK--