From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: pbonzini@redhat.com, lcapitulino@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 2/7] monitor: discard global variable *mon_cmds
Date: Thu, 27 Jun 2013 11:57:13 -0600 [thread overview]
Message-ID: <51CC7CF9.4090105@redhat.com> (raw)
In-Reply-To: <1372078125-31085-3-git-send-email-xiawenc@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
On 06/24/2013 06:48 AM, Wenchao Xia wrote:
> New member *cmd_table is added in structure Monitor to avoid direct usage of
> *mon_cmds. Now monitor have an associated command table, when global variable
> *info_cmds is also discarded, structure Monitor would gain full control about
> how to deal with user input.
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> monitor.c | 14 +++++++++-----
> 1 files changed, 9 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-06-27 17:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 12:48 [Qemu-devel] [PATCH V2 0/7] monitor: support sub command group in auto completion and help Wenchao Xia
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 1/7] monitor: discard global variable *cur_mon in completion functions Wenchao Xia
2013-06-27 17:45 ` Eric Blake
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 2/7] monitor: discard global variable *mon_cmds Wenchao Xia
2013-06-27 17:57 ` Eric Blake [this message]
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 3/7] monitor: discard global variable *info_cmds in help functions Wenchao Xia
2013-06-27 19:26 ` Eric Blake
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 4/7] monitor: code move for parse_cmdline() Wenchao Xia
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 5/7] monitor: support sub commands in auto completion Wenchao Xia
2013-06-26 4:03 ` Wenchao Xia
2013-06-26 16:03 ` Luiz Capitulino
2013-06-27 1:43 ` Wenchao Xia
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 6/7] monitor: improve "help" in auto completion for sub command Wenchao Xia
2013-06-24 12:48 ` [Qemu-devel] [PATCH V2 7/7] monitor: improve "help" to allow show tip of single command in sub group Wenchao Xia
2013-06-27 17:17 ` [Qemu-devel] [PATCH V2 0/7] monitor: support sub command group in auto completion and help Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC7CF9.4090105@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).