From: Richard Henderson <rth@twiddle.net>
To: Petar Jovanovic <Petar.Jovanovic@imgtec.com>
Cc: Petar Jovanovic <petar.jovanovic@rt-rk.com>,
"aurelien@aurel32.net" <aurelien@aurel32.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15
Date: Thu, 27 Jun 2013 11:26:20 -0700 [thread overview]
Message-ID: <51CC83CC.6060404@twiddle.net> (raw)
In-Reply-To: <56EA75BA695AE044ACFB41322F6D2BF4022320D1@BADAG02.ba.imgtec.org>
On 06/17/2013 03:40 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Multiplication of Q15 fractional halfword vectors was incorrect in the
> previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take
> element signs into account. This change fixes it, and it adds a test case
> for it.
>
> The change also removes unnecessary cast in the function
> mipsdsp_mul_q15_q15_overflowflag21().
>
> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++-
> 2 files changed, 20 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2013-06-27 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 17:37 [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 Petar Jovanovic
2013-06-09 2:36 ` Petar Jovanovic
2013-06-17 22:40 ` Petar Jovanovic
2013-06-25 10:19 ` Petar Jovanovic
2013-06-27 18:26 ` Richard Henderson [this message]
2013-07-08 9:20 ` Petar Jovanovic
2013-07-15 11:46 ` Petar Jovanovic
2013-07-22 8:52 ` Petar Jovanovic
2013-07-27 23:35 ` Petar Jovanovic
2013-07-28 16:28 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC83CC.6060404@twiddle.net \
--to=rth@twiddle.net \
--cc=Petar.Jovanovic@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=petar.jovanovic@rt-rk.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).