From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsGto-0008LZ-Su for qemu-devel@nongnu.org; Thu, 27 Jun 2013 14:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsGtl-00081U-03 for qemu-devel@nongnu.org; Thu, 27 Jun 2013 14:26:28 -0400 Received: from mail-yh0-x22b.google.com ([2607:f8b0:4002:c01::22b]:36480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsGtk-00081N-Sx for qemu-devel@nongnu.org; Thu, 27 Jun 2013 14:26:24 -0400 Received: by mail-yh0-f43.google.com with SMTP id b12so591481yha.16 for ; Thu, 27 Jun 2013 11:26:24 -0700 (PDT) Sender: Richard Henderson Message-ID: <51CC83CC.6060404@twiddle.net> Date: Thu, 27 Jun 2013 11:26:20 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1369330673-122946-1-git-send-email-petar.jovanovic@rt-rk.com>, <56EA75BA695AE044ACFB41322F6D2BF40223026F@BADAG02.ba.imgtec.org> <56EA75BA695AE044ACFB41322F6D2BF4022320D1@BADAG02.ba.imgtec.org> In-Reply-To: <56EA75BA695AE044ACFB41322F6D2BF4022320D1@BADAG02.ba.imgtec.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Petar Jovanovic Cc: Petar Jovanovic , "aurelien@aurel32.net" , "qemu-devel@nongnu.org" On 06/17/2013 03:40 PM, Petar Jovanovic wrote: > From: Petar Jovanovic > > Multiplication of Q15 fractional halfword vectors was incorrect in the > previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take > element signs into account. This change fixes it, and it adds a test case > for it. > > The change also removes unnecessary cast in the function > mipsdsp_mul_q15_q15_overflowflag21(). > > Signed-off-by: Petar Jovanovic > --- > target-mips/dsp_helper.c | 4 ++-- > tests/tcg/mips/mips32-dsp/mulq_rs_ph.c | 19 ++++++++++++++++++- > 2 files changed, 20 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~