From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsKA2-0000pj-7g for qemu-devel@nongnu.org; Thu, 27 Jun 2013 17:55:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsKA1-0000rm-96 for qemu-devel@nongnu.org; Thu, 27 Jun 2013 17:55:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsKA1-0000rZ-04 for qemu-devel@nongnu.org; Thu, 27 Jun 2013 17:55:25 -0400 Message-ID: <51CCB4CA.8050608@redhat.com> Date: Thu, 27 Jun 2013 15:55:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372246684-12499-1-git-send-email-kraxel@redhat.com> <1372246684-12499-2-git-send-email-kraxel@redhat.com> <20130626115635.5271afb3@redhat.com> In-Reply-To: <20130626115635.5271afb3@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JLVXEGDOIQDQGMVHKMXD" Subject: Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Markus Armbruster , Anthony Liguori , Gerd Hoffmann , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JLVXEGDOIQDQGMVHKMXD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2013 09:56 AM, Luiz Capitulino wrote: > On Wed, 26 Jun 2013 13:38:04 +0200 > Gerd Hoffmann wrote: >=20 >> This patch adds a fbdev monitor command to enable/disable >> the fbdev display at runtime to both qmp and hmp. >> >> +## >> +# @framebuffer-display: >=20 > Let me bike-shed: we're trying to make command's names verbs. So, we > could call this framebuffer-display-set or maybe have two commands, > framebuffer-display-enable and framebuffer-display-disable. I prefer > the latter. Having 2 commands also avoids the semantic quandary of what to do for "enable":false,"device":"/path/to/non-default" - the device parameter only makes sense when enabling the framebuffer display. >> + >> +## >> +# @FramebufferInfo: >> +# >=20 > Missing docs. >=20 >> +# Since 1.6 >> +## >> +{ 'type': 'FramebufferInfo', >> + 'data': { 'enabled': 'bool', >> + '*scale' : 'bool', >> + '*device': 'str', >=20 > Why is device optional? >=20 >> + '*vtno' : 'int' } } Also, 'vtno' isn't a word; is it worth spelling it out a bit more by naming it 'vt-number'? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2JLVXEGDOIQDQGMVHKMXD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzLTKAAoJEKeha0olJ0NqkdYH/1bOiEtZxxf1V7zXSiqW1Vmd Nn5ud9yKsXd4DVGhAXPq1mUcUMObBlYkjmWbrgb5Dc2eBig08tIBr9n/5DRjHQdn n2RjVvKnAx1/0HggUT+Lx/Jdd/ONCs1si/z9d6wKTXkyvigTlAD+baSpxr8x2heA Er36lSxa9vbphkMZSA6UcR8Say1zafIdCV1QdsR1pL1ye0usHU3V0UHYnWgrNsoc I3svbZm21Bp0uHC+nnuJJJV0ZpTaC7gEOiiElgLPfVn9s3P5a0UDyYNIColAEhfI 71DRMi7K4oRtWAWzzXz3l2bTxaLpOCmajf6JPy2lhq0aOv1URUHrLfMon/zcMmE= =uBUK -----END PGP SIGNATURE----- ------enig2JLVXEGDOIQDQGMVHKMXD--