From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsL91-0006b4-PA for qemu-devel@nongnu.org; Thu, 27 Jun 2013 18:58:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsL90-0008CK-QJ for qemu-devel@nongnu.org; Thu, 27 Jun 2013 18:58:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsL90-0008C3-Ia for qemu-devel@nongnu.org; Thu, 27 Jun 2013 18:58:26 -0400 Message-ID: <51CCC387.6000808@redhat.com> Date: Thu, 27 Jun 2013 16:58:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372210541-28092-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372210541-28092-16-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1372210541-28092-16-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2RWGOPKBNWROFNWAPNEUI" Subject: Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2RWGOPKBNWROFNWAPNEUI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/25/2013 07:35 PM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > Using the previous patches, we're now able to timestamp the SETUP > state. Once we have this time, let the user know about it in the > schema. >=20 > Reviewed-by: Juan Quintela > Signed-off-by: Michael R. Hines Usually, Reviewed-by lines are listed _after_ S-o-b lines - signature lines are typically chronological, but the patch has to be signed before a review can have any weight at getting the patch into a pull request :) > --- > hmp.c | 4 ++++ > include/migration/migration.h | 1 + > migration.c | 9 +++++++++ > qapi-schema.json | 9 ++++++++- > 4 files changed, 22 insertions(+), 1 deletion(-) >=20 > +++ b/qapi-schema.json > @@ -578,6 +578,12 @@ > # expected downtime in milliseconds for the guest in last walk > # of the dirty bitmap. (since 1.3) > # > +# @setup-time: #optional amount of setup time spent _before_ the itera= tions > +# begin but _after_ the QMP command is issued. This is designed= to In what units? One can easily assume milliseconds, based on the docs of other elapsed time parameters, but being explicit never hurts. > +# provide an accounting of any activities (such as RDMA pinning= ) which > +# may be expensive, but do not actually occur during the iterat= ive > +# migration rounds themselves. (since 1.6) > +# > # Since: 0.14.0 > ## > { 'type': 'MigrationInfo', > @@ -586,7 +592,8 @@ > '*xbzrle-cache': 'XBZRLECacheStats', > '*total-time': 'int', > '*expected-downtime': 'int', > - '*downtime': 'int'} } > + '*downtime': 'int', > + '*setup-time' : 'int'} } We typically don't have space before ':' (as seen in the other lines just above). I can live with the patch as-is, but if you respin the series for other things, then fix those two things before adding Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2RWGOPKBNWROFNWAPNEUI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzMOHAAoJEKeha0olJ0NqMDAIAJwIqZb7IgssfNdLFKESfUr0 915eQ0Wzho/R58k7UyLWEX9V36RrjFWCKabdemqPlYk+25Rtr+j4uMCThoRRr9/5 ZIYHQMIsY5HQfiiJE/HKqhPcADAuFDegggAlgxC95JJeST1XZgztjaZo5U5cuv40 dULTUfihwMxKMxbP3Vc8t4b/OXqVaK5TGadrO6N1o9d9ijCxgoIFqzGOCjJgLKrY zjKk88qOLk/UmBHtowcRtS6qHZs4c7SyG6n1EFeKw9ch3W2ALtCUUJaEkc5EaGS2 HH322Fqk1nJbf3enl6sZpLnxdxxpXrUOnHhOWJBVsliMEbrqMuxaWjMuvMhrqD8= =cGoi -----END PGP SIGNATURE----- ------enig2RWGOPKBNWROFNWAPNEUI--