From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UsSa2-0002Vp-9v
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 02:54:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UsSa1-00047G-Bl
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 02:54:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57587)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UsSa1-00046v-4A
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 02:54:49 -0400
Message-ID: <51CD3321.3040907@redhat.com>
Date: Fri, 28 Jun 2013 08:54:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372177538-9812-1-git-send-email-cornelia.huck@de.ibm.com>
	<1372177538-9812-3-git-send-email-cornelia.huck@de.ibm.com>
	<51CC844C.5090405@weilnetz.de>
In-Reply-To: <51CC844C.5090405@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 2/3] virtio-ccw: Wire up ioeventfd.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, =?UTF-8?B?QXVyw6lsaWVuIEphcm5v?= <aurelien@aurel32.net>

Il 27/06/2013 20:28, Stefan Weil ha scritto:
> Am 25.06.2013 18:25, schrieb Cornelia Huck:
>> On hosts that support ioeventfd, make use of it for host-to-guest
>> notifications via diagnose 500.
>>
>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>> ---
>>  hw/s390x/css.c        |    2 +-
>>  hw/s390x/css.h        |    1 +
>>  hw/s390x/virtio-ccw.c |  117 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  hw/s390x/virtio-ccw.h |    7 +++
>>  target-s390x/cpu.h    |   16 +++++++
>>  target-s390x/kvm.c    |   19 ++++++++
>>  6 files changed, 161 insertions(+), 1 deletion(-)
> 
> This patch was recently committed to git master and breaks builds:
> 
> It uses event_notifier_get_fd which is only available for POSIX hosts.
> W32/W64 uses event_notifier_get_handle.
> 
> Output from broken build:
> 
>    LINK  s390x-softmmu/qemu-system-s390xw.exe
> hw/s390x/virtio-ccw.o: In function `virtio_ccw_set_guest2host_notifier':
> hw/s390x/virtio-ccw.c:92: undefined reference to `event_notifier_get_fd'
> hw/s390x/virtio-ccw.c:82: undefined reference to `event_notifier_get_fd'

The solution is simply to pass the EventNotifier to
s390_assign_subch_ioeventfd (as we do for the MemoryListener
eventfd_{add,del} callbacks, for example).

Paolo