From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsStu-00085d-2V for qemu-devel@nongnu.org; Fri, 28 Jun 2013 03:15:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsStp-0002CN-T5 for qemu-devel@nongnu.org; Fri, 28 Jun 2013 03:15:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsStp-0002CH-Jn for qemu-devel@nongnu.org; Fri, 28 Jun 2013 03:15:17 -0400 Message-ID: <51CD37F8.7070807@redhat.com> Date: Fri, 28 Jun 2013 09:15:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372210541-28092-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372210541-28092-16-git-send-email-mrhines@linux.vnet.ibm.com> <51CCC387.6000808@redhat.com> In-Reply-To: <51CCC387.6000808@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, chegu_vinod@hp.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 28/06/2013 00:58, Eric Blake ha scritto: >> Using the previous patches, we're now able to timestamp the >> SETUP state. Once we have this time, let the user know about it >> in the schema. >> >> Reviewed-by: Juan Quintela Signed-off-by: >> Michael R. Hines > > Usually, Reviewed-by lines are listed _after_ S-o-b lines - > signature lines are typically chronological, but the patch has to > be signed before a review can have any weight at getting the patch > into a pull request :) Hmm, that's not how I understood it. The last line in the message should be S-o-b. If _I_ collect the Reviewed-bys when committing, I'll do Signed-off-by: Michael R. Hines Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini But since Michael is the one collecting the tags from previous submissions of the patch series, he's placing it right. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRzTf4AAoJEBvWZb6bTYby33kP/A1oAqs6djatLmvKXwFa4uq/ XgDvn8TZq/TP+I8a3v8rvMiw8MbLYP+YBKvuwKmUb/WKHmdvDFzZeNRRI/DBVOb6 c8qMlc6sGCZW1R8+aBq1lYJf/sXlXFdE+owL4gVfujJzHdFn1N9hllWXFGxqnXDk G7mJHPsyFA2B2W+4rJvfJozvJHsT9IviA+iXcAZMqGPH22VvOzcBodeE6Y9kYTmN a3cRUkygY7wi4rTsxqbc1oQ1575FUL3xt7QPx2B47vT6C04n/mC5fCMHbgwS0oiJ +YRQap6Lnnd3FgKwpXh4lJamA7n+HT/3H5GC2nlr86MmR/sU6+zeYmksKgDhs8L1 l8QcWc+aQ0urfN29oUxhNChilI/0TWlcTIe8XyxgEpPeZ9KM4rCBVMIui0YYjaUK B4mrxpqi1s9dP4Tx4VEgr46LIx2aTen5vhurFlfHVvLse9UqX8QUwmymZJTw+OIv jLL37XfN2L2vfS8TTyr+a1Z1lrcyi0E5nY1IEm6UnH1wZB/kRdh9F5DgkPjB7tob 2GlJBBH9oNs2ohHfS3/4WdYq8zPx5rSlSqy0PfctgtIHR7+LblxLP4wcTDKm+apM yx3bfEDEyBta0js+SME0nU2gVWfTJEJBNSnARax5Sxe06/NShOtJ9vqOSUlMk4SY v5R7ZkeDsKYuKBvDHRel =n0+a -----END PGP SIGNATURE-----