From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com,
mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org,
owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com,
gokul@us.ibm.com, chegu_vinod@hp.com
Subject: Re: [Qemu-devel] [PATCH 2/6] rdma: introduce ram_handle_compressed()
Date: Fri, 28 Jun 2013 09:17:20 +0200 [thread overview]
Message-ID: <51CD3880.1050905@redhat.com> (raw)
In-Reply-To: <CAFEAcA8=DRJj6_eUsyVD7RWL-sW9ySF8oy0Lk6t+OMM27Qg-nQ@mail.gmail.com>
Il 28/06/2013 00:56, Peter Maydell ha scritto:
> On 27 June 2013 23:44, <mrhines@linux.vnet.ibm.com> wrote:
>> arch_init.c | 29 +++++++++++++++++++----------
>> include/migration/migration.h | 2 ++
>
> Implementation in arch_init.c but prototype in migration.h?
> The function pretty clearly has nothing to do with initialization
> anyway, which suggests it's just in the wrong place (along with
> a pile of other migration related code there).
Yes, this used to be in vl.c, and was moved here by Blue Swirl. We can
create a new savevm-ram.c file, but it is not really the fault of this
patch.
Paolo
next prev parent reply other threads:[~2013-06-28 7:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 22:44 [Qemu-devel] [PATCH 0/6] rdma: core logic and unpin support mrhines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 1/6] rdma: update documentation to reflect new " mrhines
2013-06-27 23:09 ` Eric Blake
2013-06-28 13:17 ` Michael R. Hines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 2/6] rdma: introduce ram_handle_compressed() mrhines
2013-06-27 22:56 ` Peter Maydell
2013-06-28 7:17 ` Paolo Bonzini [this message]
2013-06-27 22:44 ` [Qemu-devel] [PATCH 3/6] rdma: core logic mrhines
2013-06-27 23:16 ` Peter Maydell
2013-06-28 13:23 ` Michael R. Hines
2013-06-28 13:28 ` Peter Maydell
2013-06-28 14:00 ` Michael R. Hines
2013-06-28 14:07 ` Peter Maydell
2013-06-28 14:22 ` Michael R. Hines
2013-06-28 7:33 ` Paolo Bonzini
2013-06-28 14:11 ` Michael R. Hines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 4/6] rdma: allow state transitions between other states besides ACTIVE mrhines
2013-06-27 23:10 ` Eric Blake
2013-06-28 7:34 ` Paolo Bonzini
2013-06-27 22:44 ` [Qemu-devel] [PATCH 5/6] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition mrhines
2013-06-27 22:44 ` [Qemu-devel] [PATCH 6/6] rdma: account for the time spent in MIG_STATE_SETUP through QMP mrhines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD3880.1050905@redhat.com \
--to=pbonzini@redhat.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=chegu_vinod@hp.com \
--cc=gokul@us.ibm.com \
--cc=knoel@redhat.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).