From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsSwN-0001Tn-1d for qemu-devel@nongnu.org; Fri, 28 Jun 2013 03:17:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsSwM-00034Z-8k for qemu-devel@nongnu.org; Fri, 28 Jun 2013 03:17:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsSwM-00034U-1J for qemu-devel@nongnu.org; Fri, 28 Jun 2013 03:17:54 -0400 Message-ID: <51CD3880.1050905@redhat.com> Date: Fri, 28 Jun 2013 09:17:20 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372373098-5877-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372373098-5877-3-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] rdma: introduce ram_handle_compressed() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, chegu_vinod@hp.com Il 28/06/2013 00:56, Peter Maydell ha scritto: > On 27 June 2013 23:44, wrote: >> arch_init.c | 29 +++++++++++++++++++---------- >> include/migration/migration.h | 2 ++ > > Implementation in arch_init.c but prototype in migration.h? > The function pretty clearly has nothing to do with initialization > anyway, which suggests it's just in the wrong place (along with > a pile of other migration related code there). Yes, this used to be in vl.c, and was moved here by Blue Swirl. We can create a new savevm-ram.c file, but it is not really the fault of this patch. Paolo