From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsXIC-0002wD-6Y for qemu-devel@nongnu.org; Fri, 28 Jun 2013 07:56:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsXI9-0007Jf-It for qemu-devel@nongnu.org; Fri, 28 Jun 2013 07:56:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33940 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsXI9-0007JI-9U for qemu-devel@nongnu.org; Fri, 28 Jun 2013 07:56:41 -0400 Message-ID: <51CD79F5.400@suse.de> Date: Fri, 28 Jun 2013 13:56:37 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> <51CD73A4.2050107@msgid.tls.msk.ru> <51CD775A.3070006@suse.de> <51CD7899.1090909@msgid.tls.msk.ru> In-Reply-To: <51CD7899.1090909@msgid.tls.msk.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Paolo Bonzini , "Todd T. Fries" Am 28.06.2013 13:50, schrieb Michael Tokarev: > 28.06.2013 15:45, Andreas F=C3=A4rber =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> Am 28.06.2013 13:29, schrieb Michael Tokarev: >>> 28.06.2013 15:24, Peter Maydell wrote: > [] >>>> ...in particular I don't think "-display none" should >>>> mean "don't allow ctrl-c" (though -nographic should >>>> continue to have that effect), and this patch currently >>>> introduces that behaviour change. >>> >>> As Anthony said before, -nographic is legacy. So there should >>> be some more modern way to control this. That's exactly the >>> change which I don't like myself. =20 >> >>> But "don't allow ctrl-c" >>> which is currently bound to -nographic is equally wrong. >> >> What's wrong about that? Isn't Ctrl+C passed through to the guest in >> -nographic mode? I don't see how any other mode inclusing daemonize >> would need that. >=20 > Um. With either -nographic or -display none, there's no "display" > per se, and it is the "display" who relays keypresses and such into > guest. Without display, the guest becomes headless completely, not > only it does not have a monitor of a video card, but also does not > have keyboard or mouse or other similar stuff. Or it may have these, > but you can't "touch" neither keyboard nor mouse because you don't > "see" them without a display. Fun thing but here we go. >=20 > This ctrl+c handling is only about when you explicitly redirected > some other char device to guest, such as serial port. Which don't > have much to do with display I think, hence I don't understand the > logic here. The logic is that a) -nographic does have serial I/O on stdio and b) emulated serial ports may get repurposed (change order/usage) for this to work. CC'ing Alex and Blue who might remember more details. So in the end it boils down to whether we consider stdio a "display" and whether we may want to split this out into its own global variable to cleanly separate it from graphical DT_* options. Andreas >=20 > Thanks, >=20 > /mjt >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg