From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UsXSA-0000uN-8o
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 08:07:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UsXS8-0002HT-8K
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 08:07:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49912)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UsXS7-0002HB-VT
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 08:07:00 -0400
Message-ID: <51CD7C5B.10509@redhat.com>
Date: Fri, 28 Jun 2013 14:06:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru>
	<CAFEAcA_TTmepFQgzmJV49s5=j0B-iZKPLqAZ0GBMj0ASwn+P0A@mail.gmail.com>
	<51CD73A4.2050107@msgid.tls.msk.ru> <51CD775A.3070006@suse.de>
	<51CD7899.1090909@msgid.tls.msk.ru>
	<CAFEAcA9YG+vZxFz9TRjAPxYpYYEdfaG3jfFgR1bqjOsc4-V++w@mail.gmail.com>
	<51CD7C16.3040208@msgid.tls.msk.ru>
In-Reply-To: <51CD7C16.3040208@msgid.tls.msk.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC,
	use DT_NONE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, "Todd T. Fries" <todd@fries.net>, =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= <afaerber@suse.de>, qemu-devel@nongnu.org

Il 28/06/2013 14:05, Michael Tokarev ha scritto:
> That's exactly why I don't think looking at -nographic here in
> serial code is wrong.  It should do the same regardless of
> -nographic - if, say, serial is redirected to stdio, it should
> always pass Ctrl+C to guest instead of killing it.  So I'm
> not really sure we should test for -display none here, either.

See the patch I just sent.

>> > It would be nice to be able to say "-nographic is equivalent to
>> > '-display none -serial stdio -disable-ctrl-c -other-things'"
>> > but I'm not sure exactly what the -other-things are or even
>> > if we can set them all on the command line specifically.
> We have some code in sun4 which also enabled serial ports
> differently with and without -nographic, maybe because of
> the same thing (which is what this all is about!).
> 
> And there's also another place, passing this NOGRAPHIC thing
> to bios.
> 
> So far that's all.  With chardev you can explicitly control
> Ctrl+C behavour using signal={on|off} attribute.

Unfortunately, you cannot use -chardev for the vast majority of boards
(all those that have no ISA/PCI/virtio).

Paolo