From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Add non-kvm stub file
Date: Fri, 28 Jun 2013 14:12:24 +0200 [thread overview]
Message-ID: <51CD7DA8.5090002@redhat.com> (raw)
In-Reply-To: <55C99EAD-FE3C-476C-9506-3F1946EB8F65@suse.de>
Il 28/06/2013 13:56, Alexander Graf ha scritto:
>
> On 28.06.2013, at 13:54, Alexander Graf wrote:
>
>> There are cases where a kvm provided function is called from generic
>> hw code that doesn't know whether kvm is available or not. Provide
>> a stub file which can provide simple replacement functions for those
>> cases.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>
> This by itself looks quite meager. I want to prepend this to the openpic kvm patch and squash the following chunk into that one to fix broken compilation on non-ppc systems:
>
>
> diff --git a/target-ppc/kvm-stub.c b/target-ppc/kvm-stub.c
> index 0f5c27d..ee3f5d2 100644
> --- a/target-ppc/kvm-stub.c
> +++ b/target-ppc/kvm-stub.c
> @@ -10,3 +10,9 @@
> *
> */
> #include "qemu-common.h"
> +#include "hw/ppc/openpic.h"
> +
> +int kvm_openpic_connect_vcpu(DeviceState *d, CPUState *cs)
> +{
> + return -EINVAL;
> +}
>
Yup,
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2013-06-28 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 11:54 [Qemu-devel] [PATCH] PPC: Add non-kvm stub file Alexander Graf
2013-06-28 11:56 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2013-06-28 12:12 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD7DA8.5090002@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).