From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsXXb-0005mH-RO for qemu-devel@nongnu.org; Fri, 28 Jun 2013 08:12:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsXXZ-0004V2-RT for qemu-devel@nongnu.org; Fri, 28 Jun 2013 08:12:39 -0400 Message-ID: <51CD7DA8.5090002@redhat.com> Date: Fri, 28 Jun 2013 14:12:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372420474-17096-1-git-send-email-agraf@suse.de> <55C99EAD-FE3C-476C-9506-3F1946EB8F65@suse.de> In-Reply-To: <55C99EAD-FE3C-476C-9506-3F1946EB8F65@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Add non-kvm stub file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Maydell , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Il 28/06/2013 13:56, Alexander Graf ha scritto: > > On 28.06.2013, at 13:54, Alexander Graf wrote: > >> There are cases where a kvm provided function is called from generic >> hw code that doesn't know whether kvm is available or not. Provide >> a stub file which can provide simple replacement functions for those >> cases. >> >> Signed-off-by: Alexander Graf > > This by itself looks quite meager. I want to prepend this to the openpic kvm patch and squash the following chunk into that one to fix broken compilation on non-ppc systems: > > > diff --git a/target-ppc/kvm-stub.c b/target-ppc/kvm-stub.c > index 0f5c27d..ee3f5d2 100644 > --- a/target-ppc/kvm-stub.c > +++ b/target-ppc/kvm-stub.c > @@ -10,3 +10,9 @@ > * > */ > #include "qemu-common.h" > +#include "hw/ppc/openpic.h" > + > +int kvm_openpic_connect_vcpu(DeviceState *d, CPUState *cs) > +{ > + return -EINVAL; > +} > Yup, Reviewed-by: Paolo Bonzini