Re: [Qemu-devel] [Qemu-trivial] [PATCH] tls.h: Enable TLS on FreeBSD

[Paolo Bonzini <pbonzini@redhat.com>]

Il 28/06/2013 14:54, Ed Maste ha scritto:
> On 28 June 2013 06:34, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> 24.06.2013 23:21, Ed Maste wrote:
>>> Signed-off-by: Ed Maste <emaste@freebsd.org>
>>> ---
>>> I have had this in a local tree for some time, and it is needed by the
>>> BSD-user work that is now being proposed.
>>
>> So I'm not applying this to -trivial, because it caused quite some
>> discussion.  If nevertheless it's okay to apply it, please let me know.
>>
>> /mjt
> 
> An objection seemed to be that it is not really needed yet, but as
> pointed out by Peter this isn't really the case.  This patch brings us
> (FreeBSD) in line with per-thread data semantics on Linux and is used
> by qemu system emulation as well.

It brings it in line with Linux, even though FreeBSD has the same need
for TLS as OpenBSD and Windows (i.e. none).  In other words, we go from
two cases (need TLS and uses it, has no TLS and doesn't need it) to
three (we add "uses TLS with no need for it").

qemu/tls.h is currently a hack.  When it will grow to something useful
(soon), rest assured that FreeBSD will be supported properly.

Paolo

> The other discussion was all around platforms unaffected by this
> change (OpenBSD, Windows); I don't see it as an argument either for or
> against this change.  So I think it's reasonable to go in.
>