From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsYVd-0007sh-Fy for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:14:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsYVa-0002cY-0l for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:14:41 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:42146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsYVZ-0002cP-Pq for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:14:37 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Jun 2013 09:14:37 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 9DB5BC9003E for ; Fri, 28 Jun 2013 09:14:33 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5SDDYtP293732 for ; Fri, 28 Jun 2013 09:13:34 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5SDDSxA012198 for ; Fri, 28 Jun 2013 09:13:34 -0400 Message-ID: <51CD8BF4.8080302@linux.vnet.ibm.com> Date: Fri, 28 Jun 2013 09:13:24 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1372210541-28092-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372210541-28092-5-git-send-email-mrhines@linux.vnet.ibm.com> <51CCC48C.3000403@redhat.com> In-Reply-To: <51CCC48C.3000403@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 04/15] rdma: export throughput w/ MigrationStats QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com On 06/27/2013 07:02 PM, Eric Blake wrote: > On 06/25/2013 07:35 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> This exposes throughput (in megabits/sec) through QMP. >> >> Reviewed-by: Juan Quintela >> Reviewed-by: Paolo Bonzini >> Reviewed-by: Chegu Vinod >> Tested-by: Chegu Vinod >> Tested-by: Michael R. Hines >> Signed-off-by: Michael R. Hines > S-o-b should generally be first (signatures are typically appended > chronologically, and it's hard for anyone else to review or test a patch > that hasn't been posted, whereas you should always be signing patches > even on first posting :) Understood, thank you. =) >> --- >> hmp.c | 2 ++ >> include/migration/migration.h | 1 + >> migration.c | 6 ++++++ >> qapi-schema.json | 5 ++++- >> 4 files changed, 13 insertions(+), 1 deletion(-) > But as long as we are listing names, feel free to add: > > Reviewed-by: Eric Blake >