From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsYVp-00081e-AE for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:14:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsYVm-0002eY-AC for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:14:53 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:44759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsYVm-0002eT-6j for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:14:50 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Jun 2013 14:14:50 +0100 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id ECF4138C8047 for ; Fri, 28 Jun 2013 09:14:45 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5SDEkEM307386 for ; Fri, 28 Jun 2013 09:14:46 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5SDEkrf017698 for ; Fri, 28 Jun 2013 09:14:46 -0400 Message-ID: <51CD8C44.5020003@linux.vnet.ibm.com> Date: Fri, 28 Jun 2013 09:14:44 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1372210541-28092-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372210541-28092-16-git-send-email-mrhines@linux.vnet.ibm.com> <51CCC387.6000808@redhat.com> In-Reply-To: <51CCC387.6000808@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com On 06/27/2013 06:58 PM, Eric Blake wrote: > On 06/25/2013 07:35 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> Using the previous patches, we're now able to timestamp the SETUP >> state. Once we have this time, let the user know about it in the >> schema. >> >> Reviewed-by: Juan Quintela >> Signed-off-by: Michael R. Hines > Usually, Reviewed-by lines are listed _after_ S-o-b lines - signature > lines are typically chronological, but the patch has to be signed before > a review can have any weight at getting the patch into a pull request :) > >> --- >> hmp.c | 4 ++++ >> include/migration/migration.h | 1 + >> migration.c | 9 +++++++++ >> qapi-schema.json | 9 ++++++++- >> 4 files changed, 22 insertions(+), 1 deletion(-) >> >> +++ b/qapi-schema.json >> @@ -578,6 +578,12 @@ >> # expected downtime in milliseconds for the guest in last walk >> # of the dirty bitmap. (since 1.3) >> # >> +# @setup-time: #optional amount of setup time spent _before_ the iterations >> +# begin but _after_ the QMP command is issued. This is designed to > In what units? One can easily assume milliseconds, based on the docs of > other elapsed time parameters, but being explicit never hurts. > >> +# provide an accounting of any activities (such as RDMA pinning) which >> +# may be expensive, but do not actually occur during the iterative >> +# migration rounds themselves. (since 1.6) >> +# >> # Since: 0.14.0 >> ## >> { 'type': 'MigrationInfo', >> @@ -586,7 +592,8 @@ >> '*xbzrle-cache': 'XBZRLECacheStats', >> '*total-time': 'int', >> '*expected-downtime': 'int', >> - '*downtime': 'int'} } >> + '*downtime': 'int', >> + '*setup-time' : 'int'} } > We typically don't have space before ':' (as seen in the other lines > just above). I can live with the patch as-is, but if you respin the > series for other things, then fix those two things before adding > > Reviewed-by: Eric Blake > Good catches.....thank you.