From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsYmc-0002Y3-KY for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:32:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsYmX-0001YJ-U2 for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:32:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsYmX-0001Y4-Mi for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:32:09 -0400 Message-ID: <51CD9053.1090106@redhat.com> Date: Fri, 28 Jun 2013 07:32:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372210541-28092-1-git-send-email-mrhines@linux.vnet.ibm.com> <1372210541-28092-16-git-send-email-mrhines@linux.vnet.ibm.com> <51CCC387.6000808@redhat.com> <51CD37F8.7070807@redhat.com> In-Reply-To: <51CD37F8.7070807@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OIAQWBBIKJWXOATNCCKN" Subject: Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com, mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OIAQWBBIKJWXOATNCCKN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/28/2013 01:15 AM, Paolo Bonzini wrote: > Il 28/06/2013 00:58, Eric Blake ha scritto: >>> Using the previous patches, we're now able to timestamp the >>> SETUP state. Once we have this time, let the user know about it >>> in the schema. >>> >>> Reviewed-by: Juan Quintela Signed-off-by: >>> Michael R. Hines >=20 >> Usually, Reviewed-by lines are listed _after_ S-o-b lines - >> signature lines are typically chronological, but the patch has to >> be signed before a review can have any weight at getting the patch >> into a pull request :) >=20 > Hmm, that's not how I understood it. The last line in the message > should be S-o-b. If _I_ collect the Reviewed-bys when committing, I'll= do >=20 > Signed-off-by: Michael R. Hines > Reviewed-by: Juan Quintela > Signed-off-by: Paolo Bonzini That's what I meant by signatures being chronological. The _first_ line is Michael's s-o-b, since he wrote it; on any of Michael's respins where he adds signatures collected during the review process (which will only be reviewed-by or tested-by - here a review from Juan), those come next; then when the maintainer incorporates the patch into a pull request, further signatures are collected (any reviewed-by that were not incorporated by Michael because no respin was required, followed by the final s-o-b saying the maintainer modified the commit message as part of incorporating into the pull request). > But since Michael is the one collecting the tags from previous > submissions of the patch series, he's placing it right. Having Michael's s-o-b last, after reviewed-by picked up from earlier revisions, is not chronological. Maintainers add reviewed-by before their own s-o-b, but only because their s-o-b is a secondary s-o-b; I still don't see why the original author would add reviewed-by before their (lone) s-o-b. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OIAQWBBIKJWXOATNCCKN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzZBTAAoJEKeha0olJ0NqSC0H/1ec+M7WHmgAzpFTF/9dBymZ QRnceIg9W5S03A3xJVaj6ZTe9tuHkYv2EduOiv5afu3XkrwcT2qrOWkKnCRyD7ez YIAKQd7wAT82wNFDnJRZ0oPjL+sr+03OnNmDynqZzOX81yEZtKN+sA0RvNFZApZ+ lrokubYRM6hJBcKtXsGxUiZJl00h7IYpwHz5m3ZhSdKZTMW6iDR3+wpf3jqee6jK 1Rcg1HXopURpVdk/Q28vRSWFnrZsn0VOMNDUpOvkcu52I19Heo8pq6le1LDsMBZi QG8i+A9nQHFvhfDsaKeLjM+tR4D+QIqF6F5OrW3kIGun/aVa/31MCWVLqke0zDY= =pdNI -----END PGP SIGNATURE----- ------enig2OIAQWBBIKJWXOATNCCKN--