From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsZ63-0003rz-HH for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsZ61-0000e3-NQ for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:52:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39251 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsZ61-0000dy-ID for qemu-devel@nongnu.org; Fri, 28 Jun 2013 09:52:17 -0400 Message-ID: <51CD950D.8080302@suse.de> Date: Fri, 28 Jun 2013 15:52:13 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1372426996-24282-1-git-send-email-mark.cave-ayland@ilande.co.uk> In-Reply-To: <1372426996-24282-1-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] cmd646: fix build when DEBUG_IDE is enabled. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: Kevin Wolf , qemu-devel@nongnu.org Am 28.06.2013 15:43, schrieb Mark Cave-Ayland: > Make sure we use the correct TARGET/PRI macros in the debug statements. >=20 > Signed-off-by: Mark Cave-Ayland > CC: Kevin Wolf > --- > hw/ide/cmd646.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c > index a73eb9a..9916701 100644 > --- a/hw/ide/cmd646.c > +++ b/hw/ide/cmd646.c > @@ -154,7 +154,7 @@ static uint64_t bmdma_read(void *opaque, hwaddr add= r, > break; > } > #ifdef DEBUG_IDE > - printf("bmdma: readb 0x%02x : 0x%02x\n", addr, val); > + printf("bmdma: readb " TARGET_FMT_plx " : 0x%02x\n", addr, val); To remain output-compatible you could use "0x%02" HWADDR_PRIx. While touching it, "0x%02" PRIx32 would be consistent for uint32_t val. Andreas > #endif > return val; > } > @@ -170,7 +170,7 @@ static void bmdma_write(void *opaque, hwaddr addr, > } > =20 > #ifdef DEBUG_IDE > - printf("bmdma: writeb 0x%02x : 0x%02x\n", addr, val); > + printf("bmdma: writeb " TARGET_FMT_plx " : 0x%" PRIx64 "\n", addr,= val); > #endif > switch(addr & 3) { > case 0: >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg