From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Amos Kong <akong@redhat.com>,
mst@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information
Date: Fri, 28 Jun 2013 08:04:45 -0600 [thread overview]
Message-ID: <51CD97FD.1000805@redhat.com> (raw)
In-Reply-To: <87txklez5z.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On 06/26/2013 08:15 AM, Markus Armbruster wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
>
>> On Wed, 26 Jun 2013 14:00:30 +0200
>> Markus Armbruster <armbru@redhat.com> wrote:
>>
>>> Meh, I got confused and reviewed an out-of-date version. Hope it's not
>>> entirely noise.
>>
>> I don't think it is. But this series got applied to Michael's tree, so
>> if you want your comments addressed before applying to master (I think
>> we do) then it's better to state it clearly.
>
> Michael, please give Amos a chance to reply to my review.
Looks like the pull request is already live but had issues; meanwhile, I
also found an issue when reviewing the pull request:
https://lists.gnu.org/archive/html/qemu-devel/2013-06/msg05127.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-06-28 14:04 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 9:07 [Qemu-devel] [PATCH v3 0/2] mac programming over macvtap Amos Kong
2013-05-23 9:07 ` [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event Amos Kong
2013-05-23 10:24 ` Michael S. Tsirkin
2013-05-23 14:28 ` Luiz Capitulino
2013-05-23 14:43 ` Michael S. Tsirkin
2013-05-23 14:52 ` Eric Blake
2013-05-23 14:57 ` Michael S. Tsirkin
2013-05-23 15:33 ` Luiz Capitulino
2013-05-24 3:20 ` Amos Kong
2013-05-23 12:01 ` Eric Blake
2013-06-26 6:54 ` Markus Armbruster
2013-06-26 13:53 ` Luiz Capitulino
2013-05-23 9:08 ` [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information Amos Kong
2013-05-23 10:23 ` Michael S. Tsirkin
2013-05-24 4:53 ` Amos Kong
2013-05-23 12:14 ` Eric Blake
2013-05-24 3:03 ` Amos Kong
2013-06-26 7:14 ` Markus Armbruster
2013-05-23 16:03 ` Luiz Capitulino
2013-05-24 3:08 ` Amos Kong
2013-05-24 12:23 ` Luiz Capitulino
2013-05-24 12:55 ` Eric Blake
2013-05-24 13:08 ` Luiz Capitulino
2013-05-24 13:23 ` Eric Blake
2013-06-26 9:35 ` Markus Armbruster
2013-05-24 15:20 ` Markus Armbruster
2013-05-24 16:12 ` Michael S. Tsirkin
2013-05-24 18:05 ` Eric Blake
2013-05-24 20:00 ` Luiz Capitulino
2013-05-26 7:38 ` Michael S. Tsirkin
2013-05-27 8:36 ` Stefan Hajnoczi
2013-06-26 9:54 ` Markus Armbruster
2013-06-26 12:00 ` Markus Armbruster
2013-06-26 14:02 ` Luiz Capitulino
2013-06-26 14:15 ` Markus Armbruster
2013-06-28 14:04 ` Eric Blake [this message]
2013-06-28 17:27 ` Markus Armbruster
2013-07-01 3:24 ` Amos Kong
2013-07-02 6:33 ` Amos Kong
2013-07-02 9:05 ` Markus Armbruster
2013-07-02 10:40 ` Amos Kong
2013-07-02 13:27 ` Markus Armbruster
2013-07-04 3:31 ` Amos Kong
2013-07-04 6:28 ` Markus Armbruster
2013-07-11 14:05 ` Amos Kong
2013-07-12 6:32 ` Markus Armbruster
2013-07-12 7:07 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CD97FD.1000805@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).