From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsePW-0000Ms-C9 for qemu-devel@nongnu.org; Fri, 28 Jun 2013 15:32:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsePR-0007Wz-E7 for qemu-devel@nongnu.org; Fri, 28 Jun 2013 15:32:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsePR-0007Wo-4M for qemu-devel@nongnu.org; Fri, 28 Jun 2013 15:32:41 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5SJWe1E004209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 28 Jun 2013 15:32:40 -0400 Message-ID: <51CDE4D7.7090402@redhat.com> Date: Fri, 28 Jun 2013 13:32:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372429950-20923-1-git-send-email-fsimonce@redhat.com> In-Reply-To: <1372429950-20923-1-git-send-email-fsimonce@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2CJFJSHRMSTGSCQRKDJSX" Subject: Re: [Qemu-devel] [PATCH] block: add the optional file entry to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Federico Simoncelli Cc: kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CJFJSHRMSTGSCQRKDJSX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/28/2013 08:32 AM, Federico Simoncelli wrote: > This patch adds the optional file entry to the query-block output. > The value is a json-object representing the information about the > underlying file or device (when present). >=20 > Signed-off-by: Federico Simoncelli > --- > block/qapi.c | 9 ++++++++- > qapi-schema.json | 4 +++- > qmp-commands.hx | 8 ++++++++ > tests/qemu-iotests/043.out | 15 +++++++++++++++ > 4 files changed, 34 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake > +++ b/block/qapi.c > @@ -119,7 +119,7 @@ void bdrv_query_image_info(BlockDriverState *bs, > =20 > info->filename =3D g_strdup(bs->filename); > info->format =3D g_strdup(bdrv_get_format_name(bs)); > - info->virtual_size =3D total_sectors * 512; > + info->virtual_size =3D bdrv_getlength(bs); This change seems independently useful, but I'm not sure if it's worth splitting out into a separate patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2CJFJSHRMSTGSCQRKDJSX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzeTXAAoJEKeha0olJ0NqiZ0H/2yD3Xs87bsLOn70h6AynXHD Hp8nncGhTxXRuPDIAMRdl9J/Gz2aGnWJ1+PUqQUghboGECU73uKPc6k9xOJNH1RU qntjNjZ8VhHalD+gFEgA2YCuD0OM8ym87yzfRaNZJPbMKvZhBRBFI9mtPuFTNO/a g8NRXywSs8OsSt4B2TjHfCN9+Iuey10JNCCwTZLWUQfO1U8InbiYIacvppcuyyPD wb4YDw4L+FkQpuU5c0g//udN5myJ4pAk9WD11wXFiCUo0Kdq0/ZQi06k489XBgw3 AYPTy3L4R+EMle01XaqB8kZB5b15GoZyTNT5i2zKZtnq8SlLr6OKW3eX21kG/W4= =YhmG -----END PGP SIGNATURE----- ------enig2CJFJSHRMSTGSCQRKDJSX--