From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsfGE-0000Ml-GL for qemu-devel@nongnu.org; Fri, 28 Jun 2013 16:27:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsfGC-0002Bb-Hn for qemu-devel@nongnu.org; Fri, 28 Jun 2013 16:27:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsfGC-0002BQ-AF for qemu-devel@nongnu.org; Fri, 28 Jun 2013 16:27:12 -0400 Message-ID: <51CDF19A.2030505@redhat.com> Date: Fri, 28 Jun 2013 14:27:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <28e0075bf7190eeb560b6f5fadc139c54710ea3b.1372234719.git.hutao@cn.fujitsu.com> In-Reply-To: <28e0075bf7190eeb560b6f5fadc139c54710ea3b.1372234719.git.hutao@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2HWNFDGGGATGRDKCHDHEP" Subject: Re: [Qemu-devel] [PATCH v5 12/14] Implement "info memory" and "query-memory" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Vasilis Liaskovitis , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2HWNFDGGGATGRDKCHDHEP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/26/2013 03:13 AM, Hu Tao wrote: > From: Vasilis Liaskovitis >=20 > Returns total physical memory available to guest in bytes, including ho= tplugged > memory. Note that the number reported here may be different from what t= he guest > sees e.g. if the guest has not logically onlined hotplugged memory. >=20 > This functionality is provided independently of a balloon device, since= a > guest can be using ACPI memory hotplug without using a balloon device. >=20 > Signed-off-by: Vasilis Liaskovitis > Signed-off-by: Hu Tao > --- > +++ b/qapi-schema.json > @@ -3608,3 +3608,16 @@ > '*cpuid-input-ecx': 'int', > 'cpuid-register': 'X86CPURegister32', > 'features': 'int' } } > + > +## > +# @query-memory: > +# > +# Returns total memory in bytes, including hotplugged dimms > +# > +# Returns: int Not true - it returns a struct of useful memory statistics (of which, your initial implementation of the MemoryInfo has only one statistic). This struct is free to grow larger in the future, if we determine other useful things to return. > +# > +# Since: 1.6 > +## > +{ 'type': 'MemoryInfo', > + 'data': { 'total': 'int' } } > +{ 'command': 'query-memory', 'returns': 'MemoryInfo' } You've created two items (the 'MemoryInfo' type and the 'query-memory' command), so you should have two pieces of documentation (yes, I know there are pre-existing cases of undocumented types that are declared next to the sole command that uses them, but we should avoid that where possible). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2HWNFDGGGATGRDKCHDHEP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzfGaAAoJEKeha0olJ0NqULoIAKsJzSFgUocDlJ+TPViyU7v4 gw1w9XYKQTkupZi4Efgr5iZrLDjtAHfYWNxfR3wy0OfaxXvUuwfknqvPLyFndl6M iywPinmtnBUJpgmMsE2xyc2Q01b7eHgAUxIK4RAPvgNd1DPyGLe9D3PXQKu5o/iR Pi3vnxebvkRHJ9n6hhwsP95U4tDqGkzPWGJOBRy1EA61nS2hRlEAgTZGhnkpJfDp fpmmcWT3NyaGT6hE8GTiSILLS/HFdur8T8BNwbiT3tDj/D5krTrO8gW2D8lO07Yn 2SX1UDK7sgrOORoxXyl055EYZCrRnEualWiWmbTLC1oqypTqRf9W8QrPfuSt9Mg= =SQ8n -----END PGP SIGNATURE----- ------enig2HWNFDGGGATGRDKCHDHEP--