From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46704)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UsuoT-000726-9S
	for qemu-devel@nongnu.org; Sat, 29 Jun 2013 09:03:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UsuoS-0002zh-9c
	for qemu-devel@nongnu.org; Sat, 29 Jun 2013 09:03:37 -0400
Message-ID: <51CEDB21.8020301@suse.de>
Date: Sat, 29 Jun 2013 15:03:29 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1372425837-30635-1-git-send-email-afaerber@suse.de>
	<51CDC8C1.5070106@twiddle.net>
In-Reply-To: <51CDC8C1.5070106@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] cpu: Drop unnecessary dynamic casts in
	*_env_get_cpu()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Green <green@moxielogic.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, qemu-ppc <qemu-ppc@nongnu.org>, Paul Brook <paul@codesourcery.com>, Anthony Liguori <anthony@codemonkey.ws>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>

Am 28.06.2013 19:32, schrieb Richard Henderson:
> On 06/28/2013 06:23 AM, Andreas F=C3=A4rber wrote:
>> A transition from CPUFooState to FooCPU can be considered safe,
>> just like FooCPU::env access in the opposite direction.
>> The only benefit of the FOO_CPU() casts would be protection against
>> bogus CPUFooState pointers, but then surrounding code would likely
>> break, too.
>>
>> This should slightly improve interrupt etc. performance.
>>
>> Reported-by: Anthony Liguori <aliguori@us.ibm.com>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>=20
> Acked-by: Richard Henderson <rth@twiddle.net>

Thanks, applied to qom-cpu (with extended commit message):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg