From: "Andreas Färber" <afaerber@suse.de>
To: Xu Wang <cngesaint@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Xu Wang <cngesaint@outlook.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] Add infinite loop checking in img_create()
Date: Sat, 29 Jun 2013 16:32:34 +0200 [thread overview]
Message-ID: <51CEF002.7050908@suse.de> (raw)
In-Reply-To: <1372318700-25103-1-git-send-email-cngesaint@gmail.com>
Am 27.06.2013 09:38, schrieb Xu Wang:
> From: Xu Wang <cngesaint@outlook.com>
>
> If user creates a image with loop in backing file, qemu doesn't give any
> warning or error report and creation successful. If this image was opend
> by qemu, no response would occure and segment fault would happend at last.
> Hence these patches refine and export infinite loop checking in
> collect_image_info_list() and add checking into img_create(). If a loop
> would occure, an error info output and creation interrupted.
>
> Xu Wang (2):
> Refine and export infinite loop checking in collect_image_info_list()
> Check infinite loop in img_create()
In the future please use a prefix such as "qemu-img: ..." on both cover
letter and patches to indicate which part of code it concerns, and CC
the respective maintainers of that area to assure appropriate review.
Regards,
Andreas
>
> qemu-img.c | 121 ++++++++++++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 100 insertions(+), 21 deletions(-)
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-06-29 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 7:38 [Qemu-devel] [PATCH 0/2] Add infinite loop checking in img_create() Xu Wang
2013-06-27 7:38 ` [Qemu-devel] [PATCH 1/2] Refine and export infinite loop checking in collect_image_info_list() Xu Wang
2013-06-28 20:37 ` Eric Blake
2013-07-04 13:00 ` Stefan Hajnoczi
2013-07-08 7:31 ` Xu Wang
2013-06-27 7:38 ` [Qemu-devel] [PATCH 2/2] Check infinite loop in img_create() Xu Wang
2013-06-29 14:32 ` Andreas Färber [this message]
2013-07-04 13:01 ` [Qemu-devel] [PATCH 0/2] Add infinite loop checking " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CEF002.7050908@suse.de \
--to=afaerber@suse.de \
--cc=cngesaint@gmail.com \
--cc=cngesaint@outlook.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).