From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57824)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtCe5-00005R-O0
	for qemu-devel@nongnu.org; Sun, 30 Jun 2013 04:06:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtCe4-0005U2-I4
	for qemu-devel@nongnu.org; Sun, 30 Jun 2013 04:06:05 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43561 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UtCe4-0005TK-BX
	for qemu-devel@nongnu.org; Sun, 30 Jun 2013 04:06:04 -0400
Message-ID: <51CFE6E7.1030109@suse.de>
Date: Sun, 30 Jun 2013 10:05:59 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1372055322.git.peter.crosthwaite@xilinx.com>
	<432912b7d88945eefbb3022f4334c144f153e38a.1372055322.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <432912b7d88945eefbb3022f4334c144f153e38a.1372055322.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 16/30] pci/*: QOM casting sweep
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: peter.crosthwaite@xilinx.com
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com

Am 24.06.2013 09:01, schrieb peter.crosthwaite@xilinx.com:
> diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c
> index d35c2ee..aa45e77 100644
> --- a/hw/pci/shpc.c
> +++ b/hw/pci/shpc.c
> @@ -252,9 +252,9 @@ static void shpc_free_devices_in_slot(SHPCDevice *s=
hpc, int slot)
>      for (devfn =3D PCI_DEVFN(pci_slot, 0);
>           devfn <=3D PCI_DEVFN(pci_slot, PCI_FUNC_MAX - 1);
>           ++devfn) {
> -        PCIDevice *affected_dev =3D shpc->sec_bus->devices[devfn];
> +        DeviceState *affected_dev =3D DEVICE(shpc->sec_bus->devices[de=
vfn]);
>          if (affected_dev) {

Did you verify this works as expected? Or might we need
object_dynamic_cast() here? I remember we had issues with assertions in
the past, not sure if all are resolved...

Andreas

> -            qdev_free(&affected_dev->qdev);
> +            qdev_free(affected_dev);
>          }
>      }
>  }
[snip]

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg