From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtH4u-0005F4-VG for qemu-devel@nongnu.org; Sun, 30 Jun 2013 08:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtH4u-0000xm-3S for qemu-devel@nongnu.org; Sun, 30 Jun 2013 08:50:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49245 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtH4t-0000wE-Ru for qemu-devel@nongnu.org; Sun, 30 Jun 2013 08:50:03 -0400 Message-ID: <51D02976.205@suse.de> Date: Sun, 30 Jun 2013 14:49:58 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <591685fc82b204def83305aee0dfa37cebcb89cd.1372055322.git.peter.crosthwaite@xilinx.com> In-Reply-To: <591685fc82b204def83305aee0dfa37cebcb89cd.1372055322.git.peter.crosthwaite@xilinx.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 11/30] misc/pci-testdev: QOM Upcast Sweep List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.crosthwaite@xilinx.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Am 24.06.2013 08:58, schrieb peter.crosthwaite@xilinx.com: > From: Peter Crosthwaite >=20 > Define and use standard QOM cast macro. Remove usages of DO_UPCAST > and direct -> style upcasting. >=20 > Signed-off-by: Peter Crosthwaite > --- >=20 > hw/misc/pci-testdev.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) Missed one DO_UPCAST(), fixing up. Andreas diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c index add58b7..153603e 100644 --- a/hw/misc/pci-testdev.c +++ b/hw/misc/pci-testdev.c @@ -232,7 +232,7 @@ static const MemoryRegionOps pci_testdev_pio_ops =3D = { static int pci_testdev_init(PCIDevice *pci_dev) { - PCITestDevState *d =3D DO_UPCAST(PCITestDevState, dev, pci_dev); + PCITestDevState *d =3D PCI_TEST_DEV(pci_dev); uint8_t *pci_conf; char *name; int r, i; --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg