From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtQtI-0004wV-8r for qemu-devel@nongnu.org; Sun, 30 Jun 2013 19:18:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtQtG-0002la-L1 for qemu-devel@nongnu.org; Sun, 30 Jun 2013 19:18:44 -0400 Message-ID: <51D0BCCD.7080507@suse.de> Date: Mon, 01 Jul 2013 01:18:37 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1372556709-23868-1-git-send-email-agraf@suse.de> <1372556709-23868-9-git-send-email-agraf@suse.de> <51CFCC94.9030606@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 08/32] kvm/openpic: in-kernel mpic support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Blue Swirl , qemu-ppc@nongnu.org, Anthony Liguori , Scott Wood , Aurelien Jarno Am 01.07.2013 01:01, schrieb Alexander Graf: >=20 > On 30.06.2013, at 08:13, Andreas F=E4rber wrote: >=20 >> Am 30.06.2013 03:44, schrieb Alexander Graf: >>> From: Scott Wood >>> >>> Enables support for the in-kernel MPIC that thas been merged into the >>> KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex >>> Graf (along with some other improvements). >>> >>> Note from Alex regarding kvm_irqchip_create(): >>> >>> On x86, one would call kvm_irqchip_create() to initialize an >>> in-kernel interrupt controller. That function then goes ahead and >>> initializes global capability variables as well as the default irq >>> routing table. >>> >>> On ppc, we can't call kvm_irqchip_create() because we can have >>> different types of interrupt controllers. So we want to do all the >>> things that function would do for us in the in-kernel device init >>> handler. >>> >>> Signed-off-by: Scott Wood >>> [agraf: squash in kvm_irqchip_commit_routes patch, fix non-kvm build] >>> Signed-off-by: Alexander Graf >>> --- >>> default-configs/ppc-softmmu.mak | 1 + >>> default-configs/ppc64-softmmu.mak | 1 + >>> hw/intc/Makefile.objs | 1 + >>> hw/intc/openpic_kvm.c | 252 +++++++++++++++++++++++++++++= +++++++++ >>> hw/ppc/e500.c | 79 +++++++++++- >>> include/hw/ppc/openpic.h | 2 +- >>> target-ppc/kvm-stub.c | 6 + >>> 7 files changed, 336 insertions(+), 6 deletions(-) >>> create mode 100644 hw/intc/openpic_kvm.c >> >> I had objected to the subject >=20 > What's wrong with the subject? I don't find it misleading. I don't reme= mber we ever had strong ruling on subject lines. In fact, I usually forma= t mine completely differently. ...and I have complained about that often enough, which you are ignoring. >> , and this patch is not bisectable since >> you didn't squash my ppcemb-softmmu build fix. Please do. >=20 > Please send build fixes separately from QOM refactoring. The patch as a= whole is way too big to get squashed into the original patch. I'll extra= ct the build fix and pluck it up manually this time, but please keep thin= gs separate next time around. No, this was not a refactoring of in-tree code, it was a fixup that Scott should have done. Next time review and test properly, then it wouldn't have made it into your tree in the first place and I wouldn't have needed to make my hands dirty with that crap. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg