From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UtbAG-0006FC-Jv
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 06:16:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UtbAC-0000PN-QN
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 06:16:56 -0400
Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:60122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UtbAC-0000P6-LB
	for qemu-devel@nongnu.org; Mon, 01 Jul 2013 06:16:52 -0400
Received: by mail-qc0-f182.google.com with SMTP id e10so2779835qcy.27
	for <qemu-devel@nongnu.org>; Mon, 01 Jul 2013 03:16:52 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51D1570F.3080007@redhat.com>
Date: Mon, 01 Jul 2013 12:16:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1372444009-11544-1-git-send-email-pbonzini@redhat.com>
	<1372444009-11544-6-git-send-email-pbonzini@redhat.com>
	<CAPyFy2Dvt8h4i-b1t5OP9PT+s0Riue_a-APD5kRRGxPx15RWsw@mail.gmail.com>
In-Reply-To: <CAPyFy2Dvt8h4i-b1t5OP9PT+s0Riue_a-APD5kRRGxPx15RWsw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/30] exec: do not use qemu/tls.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ed Maste <emaste@freebsd.org>
Cc: qemu-devel <qemu-devel@nongnu.org>

Il 29/06/2013 01:53, Ed Maste ha scritto:
> On 28 June 2013 14:26, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> +/* This is thread-local depending on __linux__ because:
> 
> Is the comment perhaps unchanged from an earlier revision that used a
> different test?  It seems odd to me to reference __linux__ here.
> 
>> + *  - the only -user mode supporting multiple VCPU threads is linux-user
>> + *  - TCG system mode is single-threaded regarding VCPUs
>> + *  - KVM system mode is multi-threaded but limited to Linux
>> + */
>> +#if defined CONFIG_KVM || (defined CONFIG_USER_ONLY && defined CONFIG_USE_NPTL)
> 
> Also, in discussion on the FreeBSD bsd-user patch set the suggestion
> was made that we do away with a flag, and just have thread support
> always enabled.  Would you suggest this test then become KVM ||
> (USER_ONLY && (USE_NPTL || __FreeBSD__))?

I would suggest that you have something like CONFIG_USER_THREADS that
can be used by both linux-user and bsd-user.

Paolo